Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heap-allocated StructSequences #78965

Closed
eduardo-elizondo mannequin opened this issue Sep 24, 2018 · 5 comments
Closed

Heap-allocated StructSequences #78965

eduardo-elizondo mannequin opened this issue Sep 24, 2018 · 5 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir

Comments

@eduardo-elizondo
Copy link
Mannequin

eduardo-elizondo mannequin commented Sep 24, 2018

BPO 34784
Nosy @encukou, @MojoVampire, @pablogsal, @eduardo-elizondo
PRs
  • bpo-34784: Fix PyStructSequence_NewType #9524
  • bpo-34784: Posixmodule: Heap StructSequence #9665
  • bpo-34784: Prevent creating types without bases on PyTuple_Pack failure #10536
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-12-05.12:10:25.664>
created_at = <Date 2018-09-24.07:23:17.305>
labels = ['3.8', '3.7', 'library']
title = 'Heap-allocated StructSequences'
updated_at = <Date 2018-12-05.12:10:25.663>
user = 'https://github.com/eduardo-elizondo'

    bugs.python.org fields:

    activity = <Date 2018-12-05.12:10:25.663>
actor = 'petr.viktorin'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-05.12:10:25.664>
closer = 'petr.viktorin'
components = ['Library (Lib)']
creation = <Date 2018-09-24.07:23:17.305>
creator = 'eelizondo'
dependencies = []
files = []
hgrepos = []
issue_num = 34784
keywords = ['patch']
message_count = 5.0
messages = ['326205', '326946', '329834', '329882', '329939']
nosy_count = 4.0
nosy_names = ['petr.viktorin', 'josh.r', 'pablogsal', 'eelizondo']
pr_nums = ['9524', '9665', '10536']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue34784'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @eduardo-elizondo
    Copy link
    Mannequin Author

    eduardo-elizondo mannequin commented Sep 24, 2018

    PyStructSequence_NewType does not currently work. Read the full analysis here: https://mail.python.org/pipermail/python-dev/2018-September/155069.html

    This aims to fix the implementation of PyStructSequence_NewType.

    @eduardo-elizondo eduardo-elizondo mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir labels Sep 24, 2018
    @MojoVampire
    Copy link
    Mannequin

    MojoVampire mannequin commented Oct 3, 2018

    This looks like a duplicate of bpo-28709, though admittedly, that bug hasn't seen any PRs.

    @encukou
    Copy link
    Member

    encukou commented Nov 13, 2018

    New changeset 474eedf by Petr Viktorin (Eddie Elizondo) in branch 'master':
    bpo-34784: Fix PyStructSequence_NewType with heap-allocated StructSequence (GH-9665)
    474eedf

    @pablogsal
    Copy link
    Member

    PR9665 solves also bpo-28709

    @pablogsal
    Copy link
    Member

    New changeset bfb855b by Pablo Galindo in branch 'master':
    bpo-34784: Implement correct cleanup in PyStructSequence new implementation (GH-10536)
    bfb855b

    @encukou encukou closed this as completed Dec 5, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @encukou @pablogsal