Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize asyncio.Lock #78948

Closed
1st1 opened this issue Sep 21, 2018 · 4 comments
Closed

Optimize asyncio.Lock #78948

1st1 opened this issue Sep 21, 2018 · 4 comments
Labels
3.8 only security fixes 3.9 only security fixes topic-asyncio type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Sep 21, 2018

BPO 34767
Nosy @asvetlov, @1st1, @ZackerySpytz, @miss-islington
PRs
  • bpo-34767: Do not always create a collections.deque() in asyncio.Lock() #13834
  • [3.8] bpo-34767: Do not always create a collections.deque() in asyncio.Lock() (GH-13834) #13837
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-05.10:18:33.173>
created_at = <Date 2018-09-21.15:54:44.915>
labels = ['type-feature', '3.8', '3.9', 'expert-asyncio']
title = 'Optimize asyncio.Lock'
updated_at = <Date 2019-06-05.10:18:33.172>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2019-06-05.10:18:33.172>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-05.10:18:33.173>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2018-09-21.15:54:44.915>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 34767
keywords = ['patch']
message_count = 4.0
messages = ['325997', '344690', '344695', '344696']
nosy_count = 4.0
nosy_names = ['asvetlov', 'yselivanov', 'ZackerySpytz', 'miss-islington']
pr_nums = ['13834', '13837']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34767'
versions = ['Python 3.8', 'Python 3.9']
    @1st1
    Copy link
    Member Author

    1st1 commented Sep 21, 2018

    There's no point in always creating a deque() for waiters in Lock.__init__. Not all locks end up using waiters.

    @1st1 1st1 added 3.8 only security fixes topic-asyncio type-feature A feature request or enhancement labels Sep 21, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset 9aa7856 by Miss Islington (bot) (Zackery Spytz) in branch 'master':
    bpo-34767: Do not always create a collections.deque() in asyncio.Lock() (GH-13834)
    9aa7856

    @ZackerySpytz ZackerySpytz mannequin added the 3.9 only security fixes label Jun 5, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 87a865e by Miss Islington (bot) in branch '3.8':
    bpo-34767: Do not always create a collections.deque() in asyncio.Lock() (GH-13834)
    87a865e

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Jun 5, 2019

    Thanks, Zackery!

    @asvetlov asvetlov closed this as completed Jun 5, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @1st1 @asvetlov @miss-islington