Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_shutil fails with busybox unzip #78842

Closed
benjaminp opened this issue Sep 13, 2018 · 8 comments
Closed

test_shutil fails with busybox unzip #78842

benjaminp opened this issue Sep 13, 2018 · 8 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir

Comments

@benjaminp
Copy link
Contributor

BPO 34661
Nosy @benjaminp, @miss-islington
PRs
  • closes bpo-34661: Fix test_shutil if unzip doesn't support -t. #9262
  • [3.7] closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262) #9263
  • [3.6] closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262) #9264
  • bpo-34661: Fix test skipping call. #9266
  • [2.7] closes bpo-34661: Fix test_shutil if unzip doesn't support -t. #9267
  • [3.7] bpo-34661: Fix test skipping call. (GH-9266) #9269
  • [3.6] bpo-34661: Fix test skipping call. (GH-9266) #9270
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-09-13.17:08:49.462>
created_at = <Date 2018-09-13.16:52:18.563>
labels = ['3.8', '3.7', 'tests']
title = 'test_shutil fails with busybox unzip'
updated_at = <Date 2018-09-13.18:47:50.887>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2018-09-13.18:47:50.887>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-09-13.17:08:49.462>
closer = 'benjamin.peterson'
components = ['Tests']
creation = <Date 2018-09-13.16:52:18.563>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 34661
keywords = ['patch']
message_count = 8.0
messages = ['325262', '325264', '325267', '325268', '325270', '325274', '325277', '325280']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'miss-islington']
pr_nums = ['9262', '9263', '9264', '9266', '9267', '9269', '9270']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue34661'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @benjaminp
    Copy link
    Contributor Author

    BusyBox has a unzip command, but it doesn't support -t.

    ======================================================================
    FAIL: test_unzip_zipfile (test.test_shutil.TestShutil)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_shutil.py", line 1181, in test_unzip_zipfile
    subprocess.check_output(zip_cmd, stderr=subprocess.STDOUT)
subprocess.CalledProcessError: Command '['unzip', '-t', '/tmp/tmp92zs6lmt/archive.zip']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-alpine/build/Lib/test/test_shutil.py", line 1185, in test_unzip_zipfile
    self.fail(msg.format(exc, details))
AssertionError: Command '['unzip', '-t', '/tmp/tmp92zs6lmt/archive.zip']' returned non-zero exit status 1.
**Unzip Output**
unzip: unrecognized option: t
BusyBox v1.27.2 (2017-12-12 10:41:50 GMT) multi-call binary.
Usage: unzip [-lnopq] FILE[.zip] [FILE]... [-x FILE...] [-d DIR]
Extract FILEs from ZIP archive
	-l	List contents (with -q for short form)
	-n	Never overwrite files (default: ask)
	-o	Overwrite
	-p	Print to stdout
	-q	Quiet
	-x FILE	Exclude FILEs
	-d DIR	Extract into DIR

    @benjaminp benjaminp added 3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir labels Sep 13, 2018
    @benjaminp
    Copy link
    Contributor Author

    New changeset a710ebd by Benjamin Peterson in branch 'master':
    closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
    a710ebd

    @miss-islington
    Copy link
    Contributor

    New changeset 1550b73 by Miss Islington (bot) in branch '3.7':
    closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
    1550b73

    @miss-islington
    Copy link
    Contributor

    New changeset 7eeb80b by Miss Islington (bot) in branch '3.6':
    closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9262)
    7eeb80b

    @benjaminp
    Copy link
    Contributor Author

    New changeset e78734d by Benjamin Peterson in branch 'master':
    bpo-34661: Fix test skipping call. (GH-9266)
    e78734d

    @benjaminp
    Copy link
    Contributor Author

    New changeset 18e2188 by Benjamin Peterson in branch '2.7':
    [2.7] closes bpo-34661: Fix test_shutil if unzip doesn't support -t. (GH-9267)
    18e2188

    @miss-islington
    Copy link
    Contributor

    New changeset 218b4bf by Miss Islington (bot) in branch '3.7':
    bpo-34661: Fix test skipping call. (GH-9266)
    218b4bf

    @miss-islington
    Copy link
    Contributor

    New changeset 81361cd by Miss Islington (bot) in branch '3.6':
    bpo-34661: Fix test skipping call. (GH-9266)
    81361cd

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington