Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyParser_SimpleParseStringFilename should be deleted #78834

Closed
ericvsmith opened this issue Sep 12, 2018 · 3 comments
Closed

PyParser_SimpleParseStringFilename should be deleted #78834

ericvsmith opened this issue Sep 12, 2018 · 3 comments
Assignees
@ericvsmith
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@ericvsmith
Copy link
Member

BPO 34653
Nosy @ericvsmith, @miss-islington
PRs
  • bpo-34653: Removed unused function PyParser_SimpleParseStringFilename. #9260
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericvsmith'
closed_at = <Date 2018-09-14.15:30:49.950>
created_at = <Date 2018-09-12.21:58:05.892>
labels = ['interpreter-core', 'type-feature', '3.8']
title = 'PyParser_SimpleParseStringFilename should be deleted'
updated_at = <Date 2018-09-14.15:30:49.948>
user = 'https://github.com/ericvsmith'

    bugs.python.org fields:

    activity = <Date 2018-09-14.15:30:49.948>
actor = 'eric.smith'
assignee = 'eric.smith'
closed = True
closed_date = <Date 2018-09-14.15:30:49.950>
closer = 'eric.smith'
components = ['Interpreter Core']
creation = <Date 2018-09-12.21:58:05.892>
creator = 'eric.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 34653
keywords = ['patch']
message_count = 3.0
messages = ['325189', '325261', '325352']
nosy_count = 2.0
nosy_names = ['eric.smith', 'miss-islington']
pr_nums = ['9260']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34653'
versions = ['Python 3.8']
    @ericvsmith
    Copy link
    Member Author

    There are 6 PyParser_SimpleParse* functions in pythonrun.c. 5 of them are documented in c-api/veryhigh.rst and appear in pythonrun.h. But PyParser_SimpleParseStringFilename is not documented and is not in any .h file.

    I propose we delete PyParser_SimpleParseStringFilename. It's not documented, it's not in a .h file, and it's not called from within Python's source. It's also trivial to implement in terms of PyParser_SimpleParseStringFlagsFilename.

    @ericvsmith ericvsmith added 3.7 (EOL) end of life 3.8 only security fixes labels Sep 12, 2018
    @ericvsmith ericvsmith self-assigned this Sep 12, 2018
    @ericvsmith ericvsmith added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Sep 12, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset 53c427e by Miss Islington (bot) (Eric V. Smith) in branch 'master':
    bpo-34653: Removed unused function PyParser_SimpleParseStringFilename. (GH-9260)
    53c427e

    @ericvsmith
    Copy link
    Member Author

    I'm not going to backport this to 3.7, just in case.

    @ericvsmith ericvsmith removed the 3.7 (EOL) end of life label Sep 14, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericvsmith ericvsmith

    Labels
    3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ericvsmith @miss-islington