Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid circular references in asyncio streams #78819

Closed
asvetlov opened this issue Sep 11, 2018 · 2 comments
Closed

Avoid circular references in asyncio streams #78819

asvetlov opened this issue Sep 11, 2018 · 2 comments
Labels
3.8 only security fixes topic-asyncio

Comments

@asvetlov
Copy link
Contributor

BPO 34638
Nosy @asvetlov, @1st1
PRs
  • bpo-34638: Store a weak reference to stream reader to break strong references loop #9201
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-09-12.18:43:38.924>
    created_at = <Date 2018-09-11.23:47:26.205>
    labels = ['3.8', 'expert-asyncio']
    title = 'Avoid circular references in asyncio streams'
    updated_at = <Date 2018-09-12.18:43:38.923>
    user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2018-09-12.18:43:38.923>
    actor = 'asvetlov'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-09-12.18:43:38.924>
    closer = 'asvetlov'
    components = ['asyncio']
    creation = <Date 2018-09-11.23:47:26.205>
    creator = 'asvetlov'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34638
    keywords = ['patch']
    message_count = 2.0
    messages = ['325095', '325164']
    nosy_count = 2.0
    nosy_names = ['asvetlov', 'yselivanov']
    pr_nums = ['9201']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue34638'
    versions = ['Python 3.8']

    @asvetlov
    Copy link
    Contributor Author

    Now we have a cross-reference between asyncio stream reader and protocol.

    It prevents objects deletion on ref-counting and requires a garbage collector run to destroy the stream.

    @asvetlov asvetlov added 3.8 only security fixes topic-asyncio labels Sep 11, 2018
    @asvetlov
    Copy link
    Contributor Author

    New changeset a5d1eb8 by Andrew Svetlov in branch 'master':
    bpo-34638: Store a weak reference to stream reader to break strong references loop (GH-9201)
    a5d1eb8

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes topic-asyncio
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant