Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make life.py use more rendering characters #47713

Closed
mvngu mannequin opened this issue Jul 29, 2008 · 4 comments
Closed

make life.py use more rendering characters #47713

mvngu mannequin opened this issue Jul 29, 2008 · 4 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@mvngu
Copy link
Mannequin

mvngu mannequin commented Jul 29, 2008

BPO 3463
Nosy @akuchling, @terryjreedy
Files
  • life.py.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-08-04.18:07:52.493>
created_at = <Date 2008-07-29.02:29:32.995>
labels = ['type-bug']
title = 'make life.py use more rendering characters'
updated_at = <Date 2008-08-04.18:07:52.316>
user = 'https://bugs.python.org/mvngu'

    bugs.python.org fields:

    activity = <Date 2008-08-04.18:07:52.316>
actor = 'akuchling'
assignee = 'none'
closed = True
closed_date = <Date 2008-08-04.18:07:52.493>
closer = 'akuchling'
components = ['Demos and Tools']
creation = <Date 2008-07-29.02:29:32.995>
creator = 'mvngu'
dependencies = []
files = ['11001']
hgrepos = []
issue_num = 3463
keywords = ['patch']
message_count = 4.0
messages = ['70375', '70610', '70671', '70708']
nosy_count = 3.0
nosy_names = ['akuchling', 'terry.reedy', 'mvngu']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3463'
versions = ['Python 3.0']
    @mvngu
    Copy link
    Mannequin Author

    mvngu mannequin commented Jul 29, 2008

    Allows life.py to use other characters for rendering (alphanumeric plus
    punctuation characters), apart from the default asterisk "*". The
    rendering character can be specified from the command line.

    @mvngu mvngu mannequin added the type-bug An unexpected behavior, bug, or error label Jul 29, 2008
    @terryjreedy
    Copy link
    Member

    Summary: This patch makes a non-essential change to a curses demo. It
    also reverses several 2.x to 3.0 edits, turning it back to 2.x code. So
    the current version must be rejected. Even if corrected, I would still
    recommend closing.

    To me, allowing any printable ascii char, even space, to represent live
    cells adds nothing to the file's value as a curses demo. Perhaps # as
    an altnative, but even that would be a distraction from the main purpose.

    The large bash-specific input chart is very nice. I wish I has had
    something like that when I worked with sh and csh. But it has little to
    do with this program in particular or Python as such and I think it
    would be a distraction if added.

    These diffs and others like them replace 3.0 code with 2.x code that in
    two cases will not work in 3.0.

    •        raise ValueError("Coordinates out of range %i,%i"% (y,x))

    + raise ValueError, "Coordinates out of range %i,%i"% (y,x)

    •            live = (i,j) in self.state

    + live = self.state.has_key( (i,j) )

    • xpos, ypos = board.X//2, board.Y//2
      + xpos, ypos = board.X/2, board.Y/2

    @mvngu
    Copy link
    Mannequin Author

    mvngu mannequin commented Aug 4, 2008

    Thank you Terry. I highly appreciate your comments.

    @akuchling
    Copy link
    Member

    I agree with tjreedy that this change is not very interesting for a demo
    program. It would be more interesting to add larger features such as
    different cellular automata, mouse or colour support, or something like
    that.

    Thanks for your patch, anyway.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @akuchling @terryjreedy