Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows : use of __pragma msvc extension without ifdef #78762

Closed
erikjanss mannequin opened this issue Sep 4, 2018 · 3 comments
Closed

Windows : use of __pragma msvc extension without ifdef #78762

erikjanss mannequin opened this issue Sep 4, 2018 · 3 comments
Labels
3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir

Comments

@erikjanss
Copy link
Mannequin

erikjanss mannequin commented Sep 4, 2018

BPO 34581
Nosy @benjaminp, @miss-islington, @erikjanss
PRs
  • bpo-34581 : conditionalize use of __pragma in Modules/socketmodule.c #9067
  • [3.7] closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067) #9070
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-09-05.06:29:47.818>
created_at = <Date 2018-09-04.21:05:20.608>
labels = ['extension-modules', 'build', '3.8']
title = 'Windows : use of __pragma msvc extension without ifdef'
updated_at = <Date 2018-09-05.06:45:07.865>
user = 'https://github.com/erikjanss'

    bugs.python.org fields:

    activity = <Date 2018-09-05.06:45:07.865>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-09-05.06:29:47.818>
closer = 'benjamin.peterson'
components = ['Extension Modules']
creation = <Date 2018-09-04.21:05:20.608>
creator = 'erikjanss'
dependencies = []
files = []
hgrepos = []
issue_num = 34581
keywords = ['patch']
message_count = 3.0
messages = ['324603', '324608', '324609']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'miss-islington', 'erikjanss']
pr_nums = ['9067', '9070']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue34581'
versions = ['Python 3.8']
    @erikjanss
    Copy link
    Mannequin Author

    erikjanss mannequin commented Sep 4, 2018

    The socketmodule uses the MSVC extension __pragma.

    The use of this extension is not enabled/disable by an #ifdef _MSC_VER.

    This prevents compilation with other compilers then MSVC on Windows.

    @erikjanss erikjanss mannequin added 3.8 only security fixes extension-modules C modules in the Modules dir build The build process and cross-build labels Sep 4, 2018
    @benjaminp
    Copy link
    Contributor

    New changeset 874809e by Benjamin Peterson (Erik Janssens) in branch 'master':
    closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067)
    874809e

    @miss-islington
    Copy link
    Contributor

    New changeset 5b17d7f by Miss Islington (bot) in branch '3.7':
    closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067)
    5b17d7f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington