Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctypes.find_library processing - missing parenthesis prevents subprocess from getting a returncode #78739

Closed
aixtools opened this issue Aug 31, 2018 · 4 comments
Closed

ctypes.find_library processing - missing parenthesis prevents subprocess from getting a returncode #78739

aixtools opened this issue Aug 31, 2018 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@aixtools
Copy link
Contributor

BPO 34558
Nosy @aixtools, @Mariatta, @miss-islington
PRs
  • bpo-34558: fix typo in _aix.py #9017
  • [3.7] bpo-34558: Add missing parentheses in _aix.py (GH-9017) #9023
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-09-01.02:36:46.169>
created_at = <Date 2018-08-31.19:24:42.251>
labels = ['3.7', 'tests', '3.8', 'type-bug', 'library']
title = 'ctypes.find_library processing - missing parenthesis prevents subprocess from getting a returncode'
updated_at = <Date 2018-09-01.02:46:36.990>
user = 'https://github.com/aixtools'

    bugs.python.org fields:

    activity = <Date 2018-09-01.02:46:36.990>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-09-01.02:36:46.169>
closer = 'Mariatta'
components = ['Library (Lib)', 'Tests']
creation = <Date 2018-08-31.19:24:42.251>
creator = 'Michael.Felt'
dependencies = []
files = []
hgrepos = []
issue_num = 34558
keywords = ['patch']
message_count = 4.0
messages = ['324441', '324457', '324458', '324459']
nosy_count = 3.0
nosy_names = ['Michael.Felt', 'Mariatta', 'miss-islington']
pr_nums = ['9017', '9023']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34558'
versions = ['Python 3.7', 'Python 3.8']
    @aixtools
    Copy link
    Contributor Author

    With AIX I have seen the following messages repeatedly:

    root@x066:[/data/prj/python/python3-3.8]./python ../git/*3.8/Lib/ctypes/test/test_loading.py
    /data/prj/python/git/python3-3.8/Lib/subprocess.py:852: ResourceWarning: subprocess 11796734 is still running
    ResourceWarning, source=self)
    /data/prj/python/git/python3-3.8/Lib/subprocess.py:852: ResourceWarning: subprocess 11796480 is still running
    ResourceWarning, source=self)

    There is python2 to python3 missed change typo that is preventing the returncode from ever being determined

    diff --git a/Lib/ctypes/_aix.py b/Lib/ctypes/_aix.py
index 463f60a284..190cac6507 100644
--- a/Lib/ctypes/_aix.py
+++ b/Lib/ctypes/_aix.py
@@ -115,7 +115,7 @@ def get_ld_headers(file):
         else:
             break
     p.stdout.close()
-    p.wait
+    p.wait()
     return ldr_headers
     def get_shared(ld_headers):

    PR will be posted.

    @aixtools aixtools added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Aug 31, 2018
    @Mariatta
    Copy link
    Member

    Mariatta commented Sep 1, 2018

    New changeset 172a71f by Mariatta (Michael Felt) in branch 'master':
    bpo-34558: Add missing parentheses in _aix.py (GH-9017)
    172a71f

    @Mariatta
    Copy link
    Member

    Mariatta commented Sep 1, 2018

    Thanks!

    @Mariatta Mariatta closed this as completed Sep 1, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset 89c9043 by Miss Islington (bot) in branch '3.7':
    bpo-34558: Add missing parentheses in _aix.py (GH-9017)
    89c9043

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @Mariatta @aixtools @miss-islington