Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF_VSOCK not unset because of wrong nesting #78736

Closed
mcduke mannequin opened this issue Aug 31, 2018 · 3 comments
Closed

AF_VSOCK not unset because of wrong nesting #78736

mcduke mannequin opened this issue Aug 31, 2018 · 3 comments
Labels
3.7 (EOL) end of life build The build process and cross-build extension-modules C modules in the Modules dir

Comments

@mcduke
Copy link
Mannequin

mcduke mannequin commented Aug 31, 2018

BPO 34555
Nosy @benjaminp, @miss-islington, @mcduke
PRs
  • bpo-34555: Fix incorrectly nested test for HAVE_LINUX_VM_SOCKETS_H #9016
  • [3.7] closes bpo-34555: Fix incorrectly nested test for HAVE_LINUX_VM_SOCKETS_H (GH-9016) #9029
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-09-01.22:14:01.248>
created_at = <Date 2018-08-31.15:12:14.118>
labels = ['extension-modules', 'build', '3.7']
title = 'AF_VSOCK not unset because of wrong nesting'
updated_at = <Date 2018-09-01.22:30:48.795>
user = 'https://github.com/mcduke'

    bugs.python.org fields:

    activity = <Date 2018-09-01.22:30:48.795>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-09-01.22:14:01.248>
closer = 'benjamin.peterson'
components = ['Extension Modules']
creation = <Date 2018-08-31.15:12:14.118>
creator = 'mcduke'
dependencies = []
files = []
hgrepos = []
issue_num = 34555
keywords = ['patch']
message_count = 3.0
messages = ['324427', '324469', '324470']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'miss-islington', 'mcduke']
pr_nums = ['9016', '9029']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue34555'
versions = ['Python 3.7']
    @mcduke
    Copy link
    Mannequin Author

    mcduke mannequin commented Aug 31, 2018

    If ./configure runs with the following result...

    checking for linux/vm_sockets.h... no
    checking for sockaddr_alg... no

    ...then the result of the first check is treated as if it was "yes". This is because the logic for disabling the vm_sockets functionality is nested inside an #ifdef HAVE_SOCKADDR_ALG.

    This leads to compilation errors:

    In file included from ./Modules/socketmodule.c:283:0:
./Modules/socketmodule.h:206:24: error: field ‘vm’ has incomplete type
     struct sockaddr_vm vm;
                        ^

    @mcduke mcduke mannequin added 3.7 (EOL) end of life extension-modules C modules in the Modules dir build The build process and cross-build labels Aug 31, 2018
    @benjaminp
    Copy link
    Contributor

    New changeset 2d7102e by Benjamin Peterson (Thomas Herzog) in branch 'master':
    closes bpo-34555: Fix incorrectly nested test for HAVE_LINUX_VM_SOCKETS_H (GH-9016)
    2d7102e

    @miss-islington
    Copy link
    Contributor

    New changeset 4c532da by Miss Islington (bot) in branch '3.7':
    closes bpo-34555: Fix incorrectly nested test for HAVE_LINUX_VM_SOCKETS_H (GH-9016)
    4c532da

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life build The build process and cross-build extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington