Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional aliases for HP Roman 8 #78700

Closed
michael-o mannequin opened this issue Aug 27, 2018 · 7 comments
Closed

Add additional aliases for HP Roman 8 #78700

michael-o mannequin opened this issue Aug 27, 2018 · 7 comments
Labels
3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@michael-o
Copy link
Mannequin

michael-o mannequin commented Aug 27, 2018

BPO 34519
Nosy @malemburg, @jaraco, @serhiy-storchaka, @michael-o
PRs
  • bpo-34519: Add additional aliases for HP Roman 8 #8956
  • [3.8] bpo-34519: Add additional aliases for HP Roman 8 (GH-8956) #15938
  • [3.8] bpo-34519: Add additional aliases for HP Roman 8 (GH-8956) #15945
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-11.14:21:44.728>
created_at = <Date 2018-08-27.13:39:51.828>
labels = ['3.8', 'type-feature', 'library', '3.9']
title = 'Add additional aliases for HP Roman 8'
updated_at = <Date 2019-09-11.14:21:44.727>
user = 'https://github.com/michael-o'

    bugs.python.org fields:

    activity = <Date 2019-09-11.14:21:44.727>
actor = 'jaraco'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-11.14:21:44.728>
closer = 'jaraco'
components = ['Library (Lib)']
creation = <Date 2018-08-27.13:39:51.828>
creator = 'michael-o'
dependencies = []
files = []
hgrepos = []
issue_num = 34519
keywords = ['patch']
message_count = 7.0
messages = ['324178', '324228', '324229', '324399', '351845', '351854', '351894']
nosy_count = 4.0
nosy_names = ['lemburg', 'jaraco', 'serhiy.storchaka', 'michael-o']
pr_nums = ['8956', '15938', '15945']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34519'
versions = ['Python 3.8', 'Python 3.9']
    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Aug 27, 2018

    HP Roman 8 is also known as 'hp-roman8', 'cp1051' and 'ibm1051'. They are missing from the aliases.py.

    @michael-o michael-o mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Aug 27, 2018
    @serhiy-storchaka
    Copy link
    Member

    Please provide references for the definition of 'cp1051' and 'ibm1051'.

    @serhiy-storchaka
    Copy link
    Member

    The hp-roman8 codec was added in bpo-996067. The link to the original data (ftp://dkuug.dk/i18n/charmaps/HP-ROMAN8) is dead now.

    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Aug 30, 2018

    Wikipedia references it: https://en.wikipedia.org/wiki/HP_Roman#Roman-8
    as well as IBM on its pages: https://www.ibm.com/support/knowledgecenter/en/SSFKSJ_8.0.0/com.ibm.wmqfte.doc/codepages.htm

    @jaraco
    Copy link
    Member

    jaraco commented Sep 11, 2019

    As an enhancement, this change should not be backported.

    @jaraco jaraco added 3.9 only security fixes and removed 3.7 (EOL) end of life labels Sep 11, 2019
    @jaraco
    Copy link
    Member

    jaraco commented Sep 11, 2019

    New changeset a828514 by Jason R. Coombs (Michael Osipov) in branch 'master':
    bpo-34519: Add additional aliases for HP Roman 8 (GH-8956)
    a828514

    @jaraco
    Copy link
    Member

    jaraco commented Sep 11, 2019

    New changeset fef5bdc by Jason R. Coombs (Miss Islington (bot)) in branch '3.8':
    bpo-34519: Add additional aliases for HP Roman 8 (GH-8956) (GH-15945)
    fef5bdc

    @jaraco jaraco closed this as completed Sep 11, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @jaraco @serhiy-storchaka