Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_datetime: Missing NULL check in tzinfo_from_isoformat_results() #78652

Closed
izbyshev mannequin opened this issue Aug 23, 2018 · 3 comments
Closed

_datetime: Missing NULL check in tzinfo_from_isoformat_results() #78652

izbyshev mannequin opened this issue Aug 23, 2018 · 3 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@izbyshev
Copy link
Mannequin

izbyshev mannequin commented Aug 23, 2018

BPO 34471
Nosy @abalkin, @benjaminp, @serhiy-storchaka, @pganssle, @izbyshev, @miss-islington
PRs
  • bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat… #8869
  • [3.7] closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869) #8901
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-08-24.15:53:23.338>
created_at = <Date 2018-08-23.10:14:40.927>
labels = ['extension-modules', '3.8', 'type-bug', '3.7']
title = '_datetime: Missing NULL check in tzinfo_from_isoformat_results()'
updated_at = <Date 2018-08-24.16:14:01.901>
user = 'https://github.com/izbyshev'

    bugs.python.org fields:

    activity = <Date 2018-08-24.16:14:01.901>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-08-24.15:53:23.338>
closer = 'benjamin.peterson'
components = ['Extension Modules']
creation = <Date 2018-08-23.10:14:40.927>
creator = 'izbyshev'
dependencies = []
files = []
hgrepos = []
issue_num = 34471
keywords = ['patch']
message_count = 3.0
messages = ['323934', '324005', '324006']
nosy_count = 6.0
nosy_names = ['belopolsky', 'benjamin.peterson', 'serhiy.storchaka', 'p-ganssle', 'izbyshev', 'miss-islington']
pr_nums = ['8869', '8901']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34471'
versions = ['Python 3.7', 'Python 3.8']
    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Aug 23, 2018

    The return value of new_delta() is not checked for NULL at

    cpython/Modules/_datetimemodule.c

    Line 1292 in ccd9975

    PyObject *delta = new_delta(0, tzoffset, tz_useconds, 1);
    and then dereferenced.

    Reported by Svace static analyzer.

    @izbyshev izbyshev mannequin added 3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Aug 23, 2018
    @benjaminp
    Copy link
    Contributor

    New changeset 4988453 by Benjamin Peterson (Alexey Izbyshev) in branch 'master':
    closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869)
    4988453

    @miss-islington
    Copy link
    Contributor

    New changeset c7f5435 by Miss Islington (bot) in branch '3.7':
    closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869)
    c7f5435

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @benjaminp @miss-islington