Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose venv --prompt value to an environment value #78620

Closed
Tadaboody mannequin opened this issue Aug 20, 2018 · 3 comments
Closed

Expose venv --prompt value to an environment value #78620

Tadaboody mannequin opened this issue Aug 20, 2018 · 3 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@Tadaboody
Copy link
Mannequin

Tadaboody mannequin commented Aug 20, 2018

BPO 34439
Nosy @vsajip, @tirkarthi, @Tadaboody

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-01-07.03:35:06.968>
created_at = <Date 2018-08-20.10:20:49.950>
labels = ['3.8', 'type-bug', 'library']
title = 'Expose venv --prompt value to an environment value'
updated_at = <Date 2019-01-07.03:35:06.964>
user = 'https://github.com/Tadaboody'

bugs.python.org fields:

activity = <Date 2019-01-07.03:35:06.964>
actor = 'vinay.sajip'
assignee = 'none'
closed = True
closed_date = <Date 2019-01-07.03:35:06.968>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2018-08-20.10:20:49.950>
creator = 'Tomer'
dependencies = []
files = []
hgrepos = []
issue_num = 34439
keywords = []
message_count = 3.0
messages = ['323782', '333042', '333132']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'xtreak', 'Tomer']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34439'
versions = ['Python 3.8']
@Tadaboody
Copy link
Mannequin Author

Tadaboody mannequin commented Aug 20, 2018

In the same way the $VIRTUAL_ENV variable tells the virtual environment directory, A variable such as $VENV_NAME or $VENV_PROMPT should tell the value given to the venv --prompt option (Introduced in bpo-22829).

An individual could override the EnvBuilder class like the docs say, but that wouldn't insure any user will have the variable set. This is crucial for usage in custom libraries that want to display the given prompt.

@Tadaboody Tadaboody mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Aug 20, 2018
@tirkarthi
Copy link
Member

bpo-35328 seems like a related issue with a PR that sets VIRTUAL_ENV_PROMPT. Also see bpo-35661 to store the venv prompt in config file.

@tirkarthi tirkarthi removed the 3.7 (EOL) end of life label Jan 5, 2019
@vsajip
Copy link
Member

vsajip commented Jan 7, 2019

Duplicate of bpo-35328, which has a PR.

@vsajip vsajip closed this as completed Jan 7, 2019
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsajip @tirkarthi