Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test_gdb work on HP-UX #78582

Closed
michael-o mannequin opened this issue Aug 14, 2018 · 7 comments
Closed

Make test_gdb work on HP-UX #78582

michael-o mannequin opened this issue Aug 14, 2018 · 7 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@michael-o
Copy link
Mannequin

michael-o mannequin commented Aug 14, 2018

BPO 34401
Nosy @terryjreedy, @vstinner, @miss-islington, @michael-o
PRs
  • bpo-34401: add HP GDB version string to test_gdb #8828
  • bpo-34401: Fix test_gdb for HP GDB version string #20804
  • [3.9] bpo-34401: Fix test_gdb for HP GDB version string (GH-20804) #20805
  • [3.8] bpo-34401: Fix test_gdb for HP GDB version string (GH-20804) #20806
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-11.13:52:12.542>
created_at = <Date 2018-08-14.11:54:16.053>
labels = ['3.8', 'type-bug', 'tests', '3.9', '3.10']
title = 'Make test_gdb work on HP-UX'
updated_at = <Date 2020-06-11.14:08:34.437>
user = 'https://github.com/michael-o'

    bugs.python.org fields:

    activity = <Date 2020-06-11.14:08:34.437>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-11.13:52:12.542>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2018-08-14.11:54:16.053>
creator = 'michael-o'
dependencies = []
files = []
hgrepos = []
issue_num = 34401
keywords = ['patch']
message_count = 7.0
messages = ['323508', '323679', '323727', '371281', '371282', '371283', '371284']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'vstinner', 'miss-islington', 'michael-o']
pr_nums = ['8828', '20804', '20805', '20806']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34401'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Aug 14, 2018

    Regex in test_gdb.py needs to be changed and test can continue, though will be skipped due to old version.

    @michael-o michael-o mannequin added 3.7 (EOL) end of life tests Tests in the Lib/test dir type-crash A hard crash of the interpreter, possibly with a core dump labels Aug 14, 2018
    @michael-o michael-o mannequin changed the title Make test_gdb work on HP-UX [solution] Make test_gdb work on HP-UX Aug 14, 2018
    @michael-o michael-o mannequin changed the title [solution] Make test_gdb work on HP-UX [SOLUTION] Make test_gdb work on HP-UX Aug 15, 2018
    @terryjreedy
    Copy link
    Member

    Why did you put '[SOLUTION]' in the title? We do not use such conventions, and you provide no solution.

    Why did you mark this as 'crash'? What is the actual failure?

    @michael-o
    Copy link
    Mannequin Author

    michael-o mannequin commented Aug 18, 2018

    My bad, I initially had attached a patch as you can see, but will turn that into a PR on GitHub on Monday. That's why I had that label, but removed the patch.

    It doesn't crash, it is rather a behavior/regex issue in the test.

    Thanks for pointing out. Will get to you with a solution on Monday.

    @michael-o michael-o mannequin changed the title [SOLUTION] Make test_gdb work on HP-UX Make test_gdb work on HP-UX Aug 18, 2018
    @michael-o michael-o mannequin added type-bug An unexpected behavior, bug, or error 3.8 only security fixes and removed type-crash A hard crash of the interpreter, possibly with a core dump labels Aug 18, 2018
    @vstinner
    Copy link
    Member

    New changeset b2dca49 by Victor Stinner in branch 'master':
    bpo-34401: Fix test_gdb for HP GDB version string (GH-20804)
    b2dca49

    @vstinner
    Copy link
    Member

    Thanks Michael Osipov for the fix! It's already merged into the master branch and will be merged into 3.8 and 3.9 branches as soon as the CI tests pass on the two backport PRs.

    I don't think that it's worth it to backport the fix to 3.7: this branch is close to move to security fixes only. I prefer to reduce any risk of regression.

    @vstinner vstinner added 3.9 only security fixes 3.10 only security fixes and removed 3.7 (EOL) end of life labels Jun 11, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 5b8e3a5 by Miss Islington (bot) in branch '3.8':
    bpo-34401: Fix test_gdb for HP GDB version string (GH-20804)
    5b8e3a5

    @miss-islington
    Copy link
    Contributor

    New changeset 2f46c65 by Miss Islington (bot) in branch '3.9':
    bpo-34401: Fix test_gdb for HP GDB version string (GH-20804)
    2f46c65

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @terryjreedy @miss-islington