Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat's python implementation of filemode (fallback) doesn't behave like the C implementation #78534

Closed
GPery mannequin opened this issue Aug 7, 2018 · 2 comments
Closed
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@GPery
Copy link
Mannequin

GPery mannequin commented Aug 7, 2018

BPO 34353
Nosy @benjaminp, @GPery
PRs
  • bpo-34353: Added sockets to stat.filemode fallback python implementation #8703
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-08-10.05:12:12.612>
    created_at = <Date 2018-08-07.17:23:14.298>
    labels = ['3.8', 'type-bug', 'library']
    title = "stat's python implementation of filemode (fallback) doesn't behave like the C implementation"
    updated_at = <Date 2018-08-10.05:12:12.564>
    user = 'https://github.com/GPery'

    bugs.python.org fields:

    activity = <Date 2018-08-10.05:12:12.564>
    actor = 'benjamin.peterson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-08-10.05:12:12.612>
    closer = 'benjamin.peterson'
    components = ['Library (Lib)']
    creation = <Date 2018-08-07.17:23:14.298>
    creator = 'gpery'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34353
    keywords = ['patch']
    message_count = 2.0
    messages = ['323248', '323355']
    nosy_count = 2.0
    nosy_names = ['benjamin.peterson', 'gpery']
    pr_nums = ['8703']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34353'
    versions = ['Python 3.8']

    @GPery
    Copy link
    Mannequin Author

    GPery mannequin commented Aug 7, 2018

    stat.py (Lib/stat.py)'s implementation of filemode doesn't account for socket-type files, while _stat (Modules/_stat.c) does, using S_IFSOCK.

    @GPery GPery mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Aug 7, 2018
    @benjaminp
    Copy link
    Contributor

    New changeset b92c526 by Benjamin Peterson (GPery) in branch 'master':
    closes bpo-34353: Add sockets to stat.filemode fallback python implementation. (GH-8703)
    b92c526

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant