Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils._msvccompiler should trim INCLUDE/LIB directories #78406

Closed
zooba opened this issue Jul 25, 2018 · 3 comments
Closed

distutils._msvccompiler should trim INCLUDE/LIB directories #78406

zooba opened this issue Jul 25, 2018 · 3 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-windows stdlib Python modules in the Lib dir

Comments

@zooba
Copy link
Member

zooba commented Jul 25, 2018

BPO 34225
Nosy @pfmoore, @tjguk, @merwok, @zware, @zooba, @dstufft
PRs
  • bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash #8464
  • [3.7] bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464) #8478
  • [3.6] bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464) #8477
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2018-07-26.16:19:24.254>
    created_at = <Date 2018-07-25.14:54:28.322>
    labels = ['3.8', '3.7', 'library', 'OS-windows']
    title = 'distutils._msvccompiler should trim INCLUDE/LIB directories'
    updated_at = <Date 2018-07-29.09:02:19.890>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2018-07-29.09:02:19.890>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2018-07-26.16:19:24.254>
    closer = 'steve.dower'
    components = ['Distutils', 'Windows']
    creation = <Date 2018-07-25.14:54:28.322>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34225
    keywords = ['patch']
    message_count = 3.0
    messages = ['322361', '322414', '322616']
    nosy_count = 6.0
    nosy_names = ['paul.moore', 'tim.golden', 'eric.araujo', 'zach.ware', 'steve.dower', 'dstufft']
    pr_nums = ['8464', '8478', '8477']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue34225'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @zooba
    Copy link
    Member Author

    zooba commented Jul 25, 2018

    _msvccompiler reads the INCLUDE and LIB environment variables when building and adds each directory to the command line. However, if any of these end with os.sep (specifically, '\'), then it will escape the quoting and break the entire command.

    We should rstrip(os.sep) on each item from this list.

    @zooba zooba added 3.7 (EOL) end of life 3.8 only security fixes labels Jul 25, 2018
    @zooba zooba self-assigned this Jul 25, 2018
    @zooba zooba added stdlib Python modules in the Lib dir OS-windows labels Jul 25, 2018
    @zooba
    Copy link
    Member Author

    zooba commented Jul 26, 2018

    New changeset 5473f06 by Steve Dower in branch 'master':
    bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464)
    5473f06

    @zooba zooba closed this as completed Jul 26, 2018
    @zooba
    Copy link
    Member Author

    zooba commented Jul 29, 2018

    New changeset 8f6a7e1 by Steve Dower (Miss Islington (bot)) in branch '3.6':
    bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464)
    8f6a7e1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-windows stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant