Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_xml_etree_c leaked [68, 68, 74] references, sum=210 #78399

Closed
pablogsal opened this issue Jul 25, 2018 · 5 comments
Closed

test_xml_etree_c leaked [68, 68, 74] references, sum=210 #78399

pablogsal opened this issue Jul 25, 2018 · 5 comments
Labels
3.8 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@pablogsal
Copy link
Member

BPO 34218
Nosy @vstinner, @serhiy-storchaka, @pablogsal
PRs
  • bpo-34218: Fix a leak in _elementtree.c introduced in GH-6769. #8460
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-07-25.11:54:45.913>
    created_at = <Date 2018-07-25.08:43:52.984>
    labels = ['3.8', 'type-bug', 'tests']
    title = 'test_xml_etree_c leaked [68, 68, 74] references, sum=210'
    updated_at = <Date 2018-07-25.18:54:36.252>
    user = 'https://github.com/pablogsal'

    bugs.python.org fields:

    activity = <Date 2018-07-25.18:54:36.252>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-07-25.11:54:45.913>
    closer = 'serhiy.storchaka'
    components = ['Tests']
    creation = <Date 2018-07-25.08:43:52.984>
    creator = 'pablogsal'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34218
    keywords = ['patch']
    message_count = 5.0
    messages = ['322343', '322345', '322347', '322368', '322385']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'serhiy.storchaka', 'pablogsal']
    pr_nums = ['8460']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34218'
    versions = ['Python 3.8']

    @pablogsal
    Copy link
    Member Author

    Builder x86 Gentoo Refleaks 3.x reports that test_xml_etree_c is potentially leaking references and blocks:

    https://buildbot.python.org/all/#builders/1/builds/295

    ----------------------------------------------------------------------
    Ran 148 tests in 0.487s
    OK
    .
    test_xml_etree_c leaked [68, 68, 74] references, sum=210
    test_xml_etree_c leaked [51, 52, 52] memory blocks, sum=155
    1 test failed again:
    test_xml_etree_c
    == Tests result: FAILURE then FAILURE ==

    @pablogsal pablogsal added 3.8 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jul 25, 2018
    @serhiy-storchaka
    Copy link
    Member

    Looks like a regression introduced in bpo-29209 (02ec92f).

    @serhiy-storchaka
    Copy link
    Member

    New changeset ee98e7b by Serhiy Storchaka in branch 'master':
    bpo-34218: Fix a leak in _elementtree.c introduced in #51018. (GH-8460)
    ee98e7b

    @vstinner
    Copy link
    Member

    Is this issue really fixed? https://buildbot.python.org/all/#builders/1/builds/295 still detects leaks.

    @serhiy-storchaka
    Copy link
    Member

    This test was finished 4 hours before the leak was fixed, and a hour before this issue was opened.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants