Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

venv activate.bat reset codepage fails on windows 10 #78325

Closed
LorenzMende mannequin opened this issue Jul 18, 2018 · 3 comments
Closed

venv activate.bat reset codepage fails on windows 10 #78325

LorenzMende mannequin opened this issue Jul 18, 2018 · 3 comments
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@LorenzMende
Copy link
Mannequin

LorenzMende mannequin commented Jul 18, 2018

BPO 34144
Nosy @zooba, @miss-islington, @LorenzMende
PRs
  • bpo-34144: Fix of venv acvtivate.bat for win 10 #8321
  • [3.7] bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321) #13465
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-04-12.11:03:29.443>
created_at = <Date 2018-07-18.08:18:42.692>
labels = ['3.8', 'type-bug', 'library']
title = 'venv activate.bat reset codepage fails on windows 10'
updated_at = <Date 2019-05-21.15:41:48.006>
user = 'https://github.com/LorenzMende'

    bugs.python.org fields:

    activity = <Date 2019-05-21.15:41:48.006>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-12.11:03:29.443>
closer = 'cheryl.sabella'
components = ['Library (Lib)']
creation = <Date 2018-07-18.08:18:42.692>
creator = 'LorenzMende'
dependencies = []
files = []
hgrepos = []
issue_num = 34144
keywords = ['patch']
message_count = 3.0
messages = ['321868', '339877', '343068']
nosy_count = 4.0
nosy_names = ['steve.dower', 'miss-islington', 'LorenzMende', 'Felix Vollmer']
pr_nums = ['8321', '13465']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34144'
versions = ['Python 3.8']
    @LorenzMende
    Copy link
    Mannequin Author

    LorenzMende mannequin commented Jul 18, 2018

    environment: Windows 10 Pro German/ 1803
    cpython @master

    When running the venv activate.bat the script fails to reset the codepage to the stored.

    # Parameterformat falsch - 65001.

    It seems that version 1803 brought a small change to the output of chcp.com - a dot is appended at the output

    The issue can be solved by modifying the codepage grep of activate.bat:
    for /f "tokens=2 delims=:." %%a in ('"%SystemRoot%\System32\chcp.com"') do (...

    A pull will be requested.

    @LorenzMende LorenzMende mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Jul 18, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset 6955d44 by Miss Islington (bot) (Lorenz Mende) in branch 'master':
    bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321)
    6955d44

    @miss-islington
    Copy link
    Contributor

    New changeset 3c9c2dc by Miss Islington (bot) in branch '3.7':
    bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321)
    3c9c2dc

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @csabella @miss-islington