Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2to3 munges new lines on Windows #78289

Closed
jaraco opened this issue Jul 13, 2018 · 4 comments
Closed

2to3 munges new lines on Windows #78289

jaraco opened this issue Jul 13, 2018 · 4 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@jaraco
Copy link
Member

jaraco commented Jul 13, 2018

BPO 34108
Nosy @jaraco
PRs
  • bpo-34108: Fix double carriage return in 2to3 on Windows #8271
  • [3.7] bpo-34108: Fix double carriage return in 2to3 on Windows (GH-8271) #8275
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/jaraco'
    closed_at = <Date 2018-07-13.19:25:33.705>
    created_at = <Date 2018-07-13.12:31:21.196>
    labels = ['3.8', 'type-bug', '3.7']
    title = '2to3 munges new lines on Windows'
    updated_at = <Date 2018-07-13.19:25:33.704>
    user = 'https://github.com/jaraco'

    bugs.python.org fields:

    activity = <Date 2018-07-13.19:25:33.704>
    actor = 'jaraco'
    assignee = 'jaraco'
    closed = True
    closed_date = <Date 2018-07-13.19:25:33.705>
    closer = 'jaraco'
    components = []
    creation = <Date 2018-07-13.12:31:21.196>
    creator = 'jaraco'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 34108
    keywords = ['patch', '3.7regression']
    message_count = 4.0
    messages = ['321599', '321615', '321619', '321629']
    nosy_count = 1.0
    nosy_names = ['jaraco']
    pr_nums = ['8271', '8275']
    priority = 'high'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue34108'
    versions = ['Python 3.7', 'Python 3.8']

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 13, 2018

    In bpo-11594, we attempted to solve the newlines issue but inadvertently introduced extraneous CR before CRLF newlines when running on Windows. See #6483 (comment) for more details.

    @jaraco jaraco added 3.7 (EOL) end of life 3.8 only security fixes labels Jul 13, 2018
    @jaraco jaraco self-assigned this Jul 13, 2018
    @jaraco jaraco added the type-bug An unexpected behavior, bug, or error label Jul 13, 2018
    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 13, 2018

    The regression never got to 3.6, so this issue likely only affects 3.7+.

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 13, 2018

    New changeset cafaf04 by Jason R. Coombs in branch 'master':
    bpo-34108: Fix double carriage return in 2to3 on Windows (bpo-8271)
    cafaf04

    @jaraco
    Copy link
    Member Author

    jaraco commented Jul 13, 2018

    New changeset cf21d00 by Jason R. Coombs (Miss Islington (bot)) in branch '3.7':
    bpo-34108: Fix double carriage return in 2to3 on Windows (GH-8271) (bpo-8275)
    cf21d00

    @jaraco jaraco closed this as completed Jul 13, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant