Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPENSSL_VERSION_1_1 never defined in _hashopenssl.c #78117

Closed
laomaiweng mannequin opened this issue Jun 22, 2018 · 7 comments
Closed

OPENSSL_VERSION_1_1 never defined in _hashopenssl.c #78117

laomaiweng mannequin opened this issue Jun 22, 2018 · 7 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir

Comments

@laomaiweng
Copy link
Mannequin

laomaiweng mannequin commented Jun 22, 2018

BPO 33936
Nosy @gpshead, @tiran, @miss-islington, @@laomaiweng, @iritkatriel
PRs
  • bpo-33936: Actually define OPENSSL_VERSION_1_1 #7855
  • bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ #16140
  • [3.8] bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140) #16199
  • [3.7] bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140) #16200
  • [2.7] bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140) #16201
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-23.19:31:14.503>
created_at = <Date 2018-06-22.02:50:21.278>
labels = ['extension-modules', '3.8', 'build', '3.7', '3.9']
title = 'OPENSSL_VERSION_1_1 never defined in _hashopenssl.c'
updated_at = <Date 2022-01-23.19:31:14.503>
user = 'https://github.com/laomaiweng'

    bugs.python.org fields:

    activity = <Date 2022-01-23.19:31:14.503>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-23.19:31:14.503>
closer = 'christian.heimes'
components = ['Extension Modules']
creation = <Date 2018-06-22.02:50:21.278>
creator = 'laomaiweng'
dependencies = []
files = []
hgrepos = []
issue_num = 33936
keywords = ['patch']
message_count = 7.0
messages = ['320207', '352572', '352576', '352577', '352578', '411312', '411409']
nosy_count = 5.0
nosy_names = ['gregory.p.smith', 'christian.heimes', 'miss-islington', 'laomaiweng', 'iritkatriel']
pr_nums = ['7855', '16140', '16199', '16200', '16201']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue33936'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    @laomaiweng
    Copy link
    Mannequin Author

    laomaiweng mannequin commented Jun 22, 2018

    I'm getting a compile error in Modules/_hashopenssl.c because the file uses some pre-1.1.0 APIs even though I'm running OpenSSL 1.1.0.

    This is because this file doesn't define the OPENSSL_VERSION_1_1 macro, like Modules/_ssl.c does.

    @laomaiweng laomaiweng mannequin added extension-modules C modules in the Modules dir build The build process and cross-build labels Jun 22, 2018
    @tiran tiran added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Sep 14, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 724f1a5 by Miss Islington (bot) (Christian Heimes) in branch 'master':
    bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140)
    724f1a5

    @miss-islington
    Copy link
    Contributor

    New changeset 1ecc75a by Miss Islington (bot) in branch '3.8':
    bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140)
    1ecc75a

    @miss-islington
    Copy link
    Contributor

    New changeset 5d55d52 by Miss Islington (bot) in branch '2.7':
    bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140)
    5d55d52

    @miss-islington
    Copy link
    Contributor

    New changeset c55f695 by Miss Islington (bot) in branch '3.7':
    [3.7] bpo-33936: Don't call obsolete init methods with OpenSSL 1.1.0+ (GH-16140) (GH-16200)
    c55f695

    @iritkatriel
    Copy link
    Member

    Christian is this fixed?

    @tiran
    Copy link
    Member

    tiran commented Jan 23, 2022

    Yes, it's fixed.

    @tiran tiran closed this as completed Jan 23, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes build The build process and cross-build extension-modules C modules in the Modules dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @tiran @iritkatriel @miss-islington