Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In IDLE menudefs, change 'windows' to 'window' #78105

Closed
terryjreedy opened this issue Jun 21, 2018 · 8 comments
Closed

In IDLE menudefs, change 'windows' to 'window' #78105

terryjreedy opened this issue Jun 21, 2018 · 8 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@terryjreedy
Copy link
Member

BPO 33924
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' #7836
  • [3.7] bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836) #7837
  • [3.6] bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836) #7838
  • bpo-33924: original missed mac-specific menudef 'windows' to 'window'… #7920
  • [3.7] bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920) #7922
  • [3.6] bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920) #7923
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2018-06-21.05:59:37.230>
created_at = <Date 2018-06-21.02:06:39.413>
labels = ['3.8', 'expert-IDLE', 'type-bug', '3.7']
title = "In IDLE menudefs, change 'windows' to 'window'"
updated_at = <Date 2018-06-26.01:52:29.333>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2018-06-26.01:52:29.333>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2018-06-21.05:59:37.230>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-06-21.02:06:39.413>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 33924
keywords = ['patch']
message_count = 8.0
messages = ['320133', '320135', '320137', '320138', '320460', '320461', '320462', '320463']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['7836', '7837', '7838', '7920', '7922', '7923']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33924'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @terryjreedy
    Copy link
    Member Author

    Some time ago, IDLE's main menu item 'Windows' was changed to 'Window'. The latter seems to be pretty standard for a list of open windows. Issue bpo-33906 changed the implementation module name accordingly, from 'windows' to 'window'. This issue is about changing the 'windows' key in mainmenu.menudef to 'window'. All other keys are the lower case version of the uppercase menu item.

    editor subscripts derived menudict with ['windows'] and menu_specs, which maps menudef keys to menu names, includes ('windows': '_Window'). pyshell also has menu_specs

    Function and pseudoevent names that include 'windows'should be left alone.

    Besides the automated tests passing, the manual test will be that 'Window' works properly in all of Shell, editor window, and output window, as each is added.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Jun 21, 2018
    @terryjreedy terryjreedy self-assigned this Jun 21, 2018
    @terryjreedy terryjreedy added topic-IDLE type-bug An unexpected behavior, bug, or error labels Jun 21, 2018
    @terryjreedy
    Copy link
    Member Author

    New changeset 33c7420 by Terry Jan Reedy in branch 'master':
    bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836)
    33c7420

    @miss-islington
    Copy link
    Contributor

    New changeset e1f0dce by Miss Islington (bot) in branch '3.7':
    bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836)
    e1f0dce

    @miss-islington
    Copy link
    Contributor

    New changeset 06deaf4 by Miss Islington (bot) in branch '3.6':
    bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (GH-7836)
    06deaf4

    @terryjreedy
    Copy link
    Member Author

    New changeset 4239773 by Terry Jan Reedy (Mark Roseman) in branch 'master':
    bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920)
    4239773

    @miss-islington
    Copy link
    Contributor

    New changeset ee60e36 by Miss Islington (bot) in branch '3.7':
    bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920)
    ee60e36

    @miss-islington
    Copy link
    Contributor

    New changeset c604063 by Miss Islington (bot) in branch '3.6':
    bpo-33924: Add missed mac-specific 'windows' to 'window' changes (GH-7920)
    c604063

    @terryjreedy
    Copy link
    Member Author

    Mark's PR added two conversions, in macosx, that I missed. I rechecked a recursive case sensitive whole-word grep of 'windows' in idlelib and I believe all remaining occurrences refer to the Windows OS (usually capitalized) or multiple windows.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington