Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Rename calltips and CallTips as calltip and Calltip. #78088

Closed
terryjreedy opened this issue Jun 19, 2018 · 9 comments
Closed

IDLE: Rename calltips and CallTips as calltip and Calltip. #78088

terryjreedy opened this issue Jun 19, 2018 · 9 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 33907
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-33907: Rename an IDLE module and class. #7807
  • [3.7] bpo-33907: Rename an IDLE module and class. (GH-7807) #7808
  • [3.6] bpo-33907: Rename an IDLE module and class. (GH-7807)  #7809
  • bpo-33907: Rename an IDLE module and classes. #7810
  • [3.7] bpo-33907: Rename an IDLE module and classes. (GH-7810) #7812
  • [3.6] bpo-33907: Rename an IDLE module and classes. (GH-7810) #7813
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2018-06-20.06:41:08.266>
created_at = <Date 2018-06-19.23:04:35.571>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: Rename calltips and CallTips as calltip and Calltip.'
updated_at = <Date 2018-06-20.06:41:08.265>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2018-06-20.06:41:08.265>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2018-06-20.06:41:08.266>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-06-19.23:04:35.571>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 33907
keywords = ['patch']
message_count = 9.0
messages = ['320004', '320012', '320013', '320014', '320015', '320017', '320021', '320025', '320026']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['7807', '7808', '7809', '7810', '7812', '7813']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33907'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @terryjreedy
    Copy link
    Member Author

    Rename module 'calltips' as 'calltip'

    1. 'calltips' and 'windows' are the only two plural module names.
    2. 'calltip' fits better with 'calltip_w' (which may, however, be merged
      in 'calltip'.
      Module rename can be checked as with 'window', bpo-33906.

    and class CallTips as Calltip.
    3. This may be the only plural class name.
    4. ToolTip is singular and will be changed to Tooltip in bpo-33839. See the 6/17 and 6/19 messages.
    Needed changes in other modules will not necessarily be caught by existing tests. Use grep for 'CallTips'.

    I will not change tooltip.py (currently not used or tested) as change here would conflict with current PR for bpo-33839.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Jun 19, 2018
    @terryjreedy terryjreedy self-assigned this Jun 19, 2018
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Jun 19, 2018
    @terryjreedy
    Copy link
    Member Author

    New changeset 06e2029 by Terry Jan Reedy in branch 'master':
    bpo-33907: Rename an IDLE module and class. (GH-7807)
    06e2029

    @miss-islington
    Copy link
    Contributor

    New changeset b89a376 by Miss Islington (bot) in branch '3.7':
    bpo-33907: Rename an IDLE module and class. (GH-7807)
    b89a376

    @terryjreedy
    Copy link
    Member Author

    I also changed calltips.CallTips to calltip.Calltip, which is the same class name as for calltip_w.Calltip (formerly CallTip). This is confusing now and would block merging the files. Change the latter to calltip_w.CalltipW (for Window).

    @terryjreedy
    Copy link
    Member Author

    The calltip window class name is only used in 4 places, so I decided to expand to CalltipWindow.

    @terryjreedy
    Copy link
    Member Author

    New changeset e97a685 by Terry Jan Reedy in branch '3.6':
    [3.6] bpo-33907: Rename an IDLE module and class. (GH-7807) (GH-7809)
    e97a685

    @terryjreedy
    Copy link
    Member Author

    New changeset 9af1836 by Terry Jan Reedy in branch 'master':
    bpo-33907: Rename an IDLE module and classes. (GH-7810)
    9af1836

    @miss-islington
    Copy link
    Contributor

    New changeset ce52f5e by Miss Islington (bot) in branch '3.7':
    bpo-33907: Rename an IDLE module and classes. (GH-7810)
    ce52f5e

    @miss-islington
    Copy link
    Contributor

    New changeset 17d4c53 by Miss Islington (bot) in branch '3.6':
    bpo-33907: Rename an IDLE module and classes. (GH-7810)
    17d4c53

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington