Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code in datetime module #77991

Closed
abalkin opened this issue Jun 8, 2018 · 2 comments
Closed

Remove unused code in datetime module #77991

abalkin opened this issue Jun 8, 2018 · 2 comments
Assignees
@abalkin
Labels
3.8 only security fixes performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@abalkin
Copy link
Member

abalkin commented Jun 8, 2018

BPO 33810
Nosy @abalkin
PRs
  • bpo-33810: Remove unused code from datetime.py. #7549
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/abalkin'
closed_at = <Date 2018-06-08.23:26:57.229>
created_at = <Date 2018-06-08.21:53:38.400>
labels = ['3.8', 'library', 'performance']
title = 'Remove unused code in datetime module'
updated_at = <Date 2018-06-08.23:26:57.228>
user = 'https://github.com/abalkin'

    bugs.python.org fields:

    activity = <Date 2018-06-08.23:26:57.228>
actor = 'belopolsky'
assignee = 'belopolsky'
closed = True
closed_date = <Date 2018-06-08.23:26:57.229>
closer = 'belopolsky'
components = ['Library (Lib)']
creation = <Date 2018-06-08.21:53:38.400>
creator = 'belopolsky'
dependencies = []
files = []
hgrepos = []
issue_num = 33810
keywords = ['patch']
message_count = 2.0
messages = ['319110', '319117']
nosy_count = 1.0
nosy_names = ['belopolsky']
pr_nums = ['7549']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue33810'
versions = ['Python 3.8']
    @abalkin
    Copy link
    Member Author

    abalkin commented Jun 8, 2018

    Since implementation of bpo-25283, the objects returned by time.localtime always have tm_zone and tm_gmtoff attributes, but the datetime module still has code that anticipates these attributes to be missing. 1

    @abalkin abalkin added extension-modules C modules in the Modules dir 3.8 only security fixes labels Jun 8, 2018
    @abalkin abalkin self-assigned this Jun 8, 2018
    @abalkin abalkin added stdlib Python modules in the Lib dir performance Performance or resource usage and removed extension-modules C modules in the Modules dir labels Jun 8, 2018
    @abalkin
    Copy link
    Member Author

    abalkin commented Jun 8, 2018

    New changeset bcb032e by Alexander Belopolsky in branch 'master':
    bpo-33810 Remove unused code from datetime.py. (GH-7549)
    bcb032e

    @abalkin abalkin closed this as completed Jun 8, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @abalkin abalkin

    Labels
    3.8 only security fixes performance Performance or resource usage stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @abalkin