Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup start_tls() implementation #77950

Closed
1st1 opened this issue Jun 4, 2018 · 3 comments
Closed

Cleanup start_tls() implementation #77950

1st1 opened this issue Jun 4, 2018 · 3 comments
Assignees
@1st1
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-asyncio type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Jun 4, 2018

BPO 33769
Nosy @asvetlov, @1st1
PRs
  • bpo-33769: start_tls:Fix error message; cancel callbacks on error #7403
  • [3.7] bpo-33769: start_tls: Fix error message; cancel callbacks on error (GH-7403) #7428
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
closed_at = <Date 2018-06-05.14:18:43.217>
created_at = <Date 2018-06-04.17:45:55.442>
labels = ['3.8', 'type-feature', '3.7', 'expert-asyncio']
title = 'Cleanup start_tls() implementation'
updated_at = <Date 2018-06-05.14:18:43.216>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2018-06-05.14:18:43.216>
actor = 'yselivanov'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2018-06-05.14:18:43.217>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2018-06-04.17:45:55.442>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 33769
keywords = ['patch']
message_count = 3.0
messages = ['318688', '318750', '318760']
nosy_count = 2.0
nosy_names = ['asvetlov', 'yselivanov']
pr_nums = ['7403', '7428']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33769'
versions = ['Python 3.7', 'Python 3.8']
    @1st1
    Copy link
    Member Author

    1st1 commented Jun 4, 2018

    Current start_tls() implementation might raise an incorrect error message. It should also consistently cancel callbacks that it schedules in case of unhandled error.

    @1st1 1st1 added 3.7 (EOL) end of life 3.8 only security fixes labels Jun 4, 2018
    @1st1 1st1 self-assigned this Jun 4, 2018
    @1st1 1st1 added topic-asyncio type-feature A feature request or enhancement labels Jun 4, 2018
    @1st1
    Copy link
    Member Author

    1st1 commented Jun 5, 2018

    New changeset 415bc46 by Yury Selivanov in branch 'master':
    bpo-33769: start_tls: Fix error message; cancel callbacks on error (GH-7403)
    415bc46

    @1st1
    Copy link
    Member Author

    1st1 commented Jun 5, 2018

    New changeset 79c7e57 by Yury Selivanov (Miss Islington (bot)) in branch '3.7':
    bpo-33769: start_tls: Fix error message; cancel callbacks on error (GH-7403) (GH-7428)
    79c7e57

    @1st1 1st1 closed this as completed Jun 5, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @1st1 1st1

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @1st1