Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_posix_fallocate fails on FreeBSD buildbots with ZFS file systems #77836

Closed
ned-deily opened this issue May 26, 2018 · 5 comments
Closed
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes

Comments

@ned-deily
Copy link
Member

BPO 33655
Nosy @ned-deily, @koobs, @miss-islington
PRs
  • bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms #7134
  • [3.7] bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134) #7135
  • [3.6] bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134) #7136
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
    closed_at = <Date 2018-05-26.21:59:11.382>
    created_at = <Date 2018-05-26.19:52:51.060>
    labels = ['3.7', '3.8']
    title = 'test_posix_fallocate fails on FreeBSD buildbots with ZFS file systems'
    updated_at = <Date 2018-05-26.21:59:11.381>
    user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2018-05-26.21:59:11.381>
    actor = 'ned.deily'
    assignee = 'ned.deily'
    closed = True
    closed_date = <Date 2018-05-26.21:59:11.382>
    closer = 'ned.deily'
    components = ['FreeBSD']
    creation = <Date 2018-05-26.19:52:51.060>
    creator = 'ned.deily'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 33655
    keywords = ['patch']
    message_count = 5.0
    messages = ['317763', '317764', '317769', '317770', '317771']
    nosy_count = 3.0
    nosy_names = ['ned.deily', 'koobs', 'miss-islington']
    pr_nums = ['7134', '7135', '7136']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue33655'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @ned-deily
    Copy link
    Member Author

    Seen on some of the various FreeBSD buildbots:

    ======================================================================
    ERROR: test_posix_fallocate (test.test_posix.PosixTester)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "/usr/home/buildbot/python/3.7.koobs-freebsd-current/build/Lib/test/test_posix.py", line 342, in test_posix_fallocate
        posix.posix_fallocate(fd, 0, 10)
    OSError: [Errno 22] Invalid argument

    As discussed in bpo-31106 msg312453 and successors, the failure is due to posix_fallocate not being implemented on ZFS and the difficulty of determining in a platform-independent way what kind of file system a given file resides on. The test already ignores EINVAL ("Invalid argument") errors when run on Solaris-type platforms due to the common use of ZFS there. In lieu of a more precise test for fs type, we should also ignore EINVAL errors in this test when run on *BSD platforms. Also, rather than silently ignoring the error, it may be better to use a SkipTest message.

    @ned-deily ned-deily added 3.7 (EOL) end of life 3.8 only security fixes labels May 26, 2018
    @ned-deily ned-deily self-assigned this May 26, 2018
    @ned-deily
    Copy link
    Member Author

    New changeset 09c4a7d by Ned Deily in branch 'master':
    bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134)
    09c4a7d

    @miss-islington
    Copy link
    Contributor

    New changeset 96fb828 by Miss Islington (bot) in branch '3.7':
    bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134)
    96fb828

    @miss-islington
    Copy link
    Contributor

    New changeset ae27dee by Miss Islington (bot) in branch '3.6':
    bpo-33655: Also ignore test_posix_fallocate failures on BSD platforms (GH-7134)
    ae27dee

    @ned-deily
    Copy link
    Member Author

    Fix merged for 3.7.0 and 3.6.6.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants