Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio: transports don't support switching between Protocol and BufferedProtocol #77835

Closed
1st1 opened this issue May 26, 2018 · 8 comments
Closed

asyncio: transports don't support switching between Protocol and BufferedProtocol #77835

1st1 opened this issue May 26, 2018 · 8 comments
Assignees
@1st1
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@1st1
Copy link
Member

1st1 commented May 26, 2018

BPO 33654
Nosy @ned-deily, @asvetlov, @1st1, @miss-islington
PRs
  • bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() #7130
  • [3.7] bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130) #7164
  • bpo-33654: Support protocol type switching in SSLTransport.set_protocol() #7194
  • [3.7] bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (GH-7194) #7198
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
closed_at = <Date 2018-05-28.19:14:06.583>
created_at = <Date 2018-05-26.17:08:31.631>
labels = ['3.8', 'type-bug', '3.7', 'expert-asyncio']
title = "asyncio: transports don't support switching between Protocol and BufferedProtocol"
updated_at = <Date 2018-05-29.09:19:15.519>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2018-05-29.09:19:15.519>
actor = 'miss-islington'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2018-05-28.19:14:06.583>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2018-05-26.17:08:31.631>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 33654
keywords = ['patch']
message_count = 8.0
messages = ['317743', '317745', '317748', '317750', '317897', '317900', '317990', '317994']
nosy_count = 4.0
nosy_names = ['ned.deily', 'asvetlov', 'yselivanov', 'miss-islington']
pr_nums = ['7130', '7164', '7194', '7198']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33654'
versions = ['Python 3.7', 'Python 3.8']
    @1st1
    Copy link
    Member Author

    1st1 commented May 26, 2018

    1. asyncio.BufferedProtocol is a new Python 3.7 *provisional* API.

    2. asyncio.Transport.set_protocol() doesn't support switching between Protocol and BufferedProtocol.

    3. Because of (2), another *new* Python 3.7 API "loop.start_tls" doesn't support asyncio.BufferedProtocol at all.

    The fix is straightforward and *does not* affect any existing APIs in Python 3.6 and lower. Since the patch adjusts the APIs a little bit, it would be great to merge this in 3.7.0.

    However, since only the provisional APIs are changed, this can be theoretically merged to 3.7.1 too. It would be nice, though, to get this into 3.7.0. Ned, your thoughts?

    @1st1 1st1 added 3.7 (EOL) end of life 3.8 only security fixes labels May 26, 2018
    @1st1 1st1 self-assigned this May 26, 2018
    @1st1
    Copy link
    Member Author

    1st1 commented May 26, 2018

    Setting "release blocker" to get Ned's attention.

    @ned-deily
    Copy link
    Member

    LGTM for 3.7

    @1st1
    Copy link
    Member Author

    1st1 commented May 26, 2018

    Thanks, Ned!

    @1st1
    Copy link
    Member Author

    1st1 commented May 28, 2018

    New changeset dbf1022 by Yury Selivanov in branch 'master':
    bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130)
    dbf1022

    @miss-islington
    Copy link
    Contributor

    New changeset bc3a002 by Miss Islington (bot) in branch '3.7':
    bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (GH-7130)
    bc3a002

    @1st1 1st1 closed this as completed May 28, 2018
    @1st1 1st1 added the type-bug An unexpected behavior, bug, or error label May 28, 2018
    @asvetlov
    Copy link
    Contributor

    New changeset 2179022 by Andrew Svetlov (Yury Selivanov) in branch 'master':
    bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (bpo-7194)
    2179022

    @miss-islington
    Copy link
    Contributor

    New changeset be5d616 by Miss Islington (bot) in branch '3.7':
    bpo-33654: Support protocol type switching in SSLTransport.set_protocol() (GH-7194)
    be5d616

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @1st1 1st1

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @1st1 @asvetlov @ned-deily @miss-islington