Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused with_c_locale_warning option in configure should be removed #77829

Closed
grimreaper mannequin opened this issue May 25, 2018 · 9 comments
Closed

unused with_c_locale_warning option in configure should be removed #77829

grimreaper mannequin opened this issue May 25, 2018 · 9 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes

Comments

@grimreaper
Copy link
Mannequin

grimreaper mannequin commented May 25, 2018

BPO 33648
Nosy @ncoghlan, @vstinner, @methane, @grimreaper, @miss-islington
PRs
  • bpo-33648: remove PY_WARN_ON_C_LOCALE #7114
  • [3.7] bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114) #8250
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-07-11.11:04:11.660>
created_at = <Date 2018-05-25.14:11:51.010>
labels = ['3.7', '3.8']
title = 'unused with_c_locale_warning option in configure should be removed'
updated_at = <Date 2018-07-11.14:48:45.832>
user = 'https://github.com/grimreaper'

    bugs.python.org fields:

    activity = <Date 2018-07-11.14:48:45.832>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-11.11:04:11.660>
closer = 'methane'
components = []
creation = <Date 2018-05-25.14:11:51.010>
creator = 'eitan.adler'
dependencies = []
files = []
hgrepos = []
issue_num = 33648
keywords = ['patch']
message_count = 9.0
messages = ['317676', '317677', '317680', '317682', '321439', '321440', '321441', '321442', '321467']
nosy_count = 5.0
nosy_names = ['ncoghlan', 'vstinner', 'methane', 'eitan.adler', 'miss-islington']
pr_nums = ['7114', '8250']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue33648'
versions = ['Python 3.7', 'Python 3.8']
    @grimreaper
    Copy link
    Mannequin Author

    grimreaper mannequin commented May 25, 2018

    There is an option for --with-c-locale-warning which was turned into a run-time option in eb81795. The configuration should be cleaned up.

    @vstinner
    Copy link
    Member

    It's related to the PEP-538.

    Note: see also the PEP-540 (not directly related).

    @ncoghlan
    Copy link
    Contributor

    Huh, I thought I cleaned those out when I made the compilation unconditional. I guess not :)

    The actual fix looks good to me, but the autoconf regeneration looks unexpectedly noisy, so I've asked Benjamin Peterson to take a look at it.

    @grimreaper
    Copy link
    Mannequin Author

    grimreaper mannequin commented May 25, 2018

    yeah, I was looking at that too. I think someone else modified related files but never ran a regen (or did so with different tooling than I).

    Even on master, my regen results in changes.

    @methane
    Copy link
    Member

    methane commented Jul 11, 2018

    New changeset b91a3a0 by INADA Naoki (Eitan Adler) in branch 'master':
    bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)
    b91a3a0

    @methane
    Copy link
    Member

    methane commented Jul 11, 2018

    thanks

    @methane methane closed this as completed Jul 11, 2018
    @vstinner
    Copy link
    Member

    Should we backport the change to 3.7?

    @vstinner vstinner added the 3.8 only security fixes label Jul 11, 2018
    @methane
    Copy link
    Member

    methane commented Jul 11, 2018

    Hm, it seems safe to backport.

    @methane methane added the 3.7 (EOL) end of life label Jul 11, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset 020f5ab by Miss Islington (bot) in branch '3.7':
    bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)
    020f5ab

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @methane @ncoghlan @miss-islington