Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signatures of tp_finalize handlers in testing code. #77825

Closed
serhiy-storchaka opened this issue May 25, 2018 · 4 comments
Closed

Fix signatures of tp_finalize handlers in testing code. #77825

serhiy-storchaka opened this issue May 25, 2018 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

BPO 33644
Nosy @serhiy-storchaka, @miss-islington
PRs
  • bpo-33644: Fix signatures of tp_finalize handlers in testing code. #7111
  • [3.7] bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111) #7124
  • [3.6] bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111) #7125
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-05-26.10:17:24.468>
created_at = <Date 2018-05-25.08:49:30.566>
labels = ['3.7', '3.8', 'type-bug', 'tests']
title = 'Fix signatures of tp_finalize handlers in testing code.'
updated_at = <Date 2018-05-26.10:17:24.467>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-05-26.10:17:24.467>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-05-26.10:17:24.468>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2018-05-25.08:49:30.566>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 33644
keywords = ['patch']
message_count = 4.0
messages = ['317662', '317730', '317731', '317733']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'miss-islington']
pr_nums = ['7111', '7124', '7125']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33644'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @serhiy-storchaka
    Copy link
    Member Author

    tp_finalize handlers in Modules/_testmultiphase.c and Modules/_testmultiphase.c return int. This signature is incompatible with the signature of the tp_finalize slot. They should not return any value.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels May 25, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 19de8b3 by Serhiy Storchaka in branch 'master':
    bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111)
    19de8b3

    @miss-islington
    Copy link
    Contributor

    New changeset 14d289b by Miss Islington (bot) in branch '3.7':
    bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111)
    14d289b

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 9ba3be4 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
    bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111) (GH-7125)
    9ba3be4

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington