Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove wrapping of __set_name__ exceptions in RuntimeError #77758

Closed
carljm opened this issue May 19, 2018 · 2 comments
Closed

remove wrapping of __set_name__ exceptions in RuntimeError #77758

carljm opened this issue May 19, 2018 · 2 comments
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@carljm
Copy link
Member

carljm commented May 19, 2018

BPO 33577
Nosy @carljm

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-05-19.05:43:22.815>
created_at = <Date 2018-05-19.05:41:49.927>
labels = ['interpreter-core', '3.8']
title = 'remove wrapping of __set_name__ exceptions in RuntimeError'
updated_at = <Date 2018-05-19.05:43:22.814>
user = 'https://github.com/carljm'

bugs.python.org fields:

activity = <Date 2018-05-19.05:43:22.814>
actor = 'carljm'
assignee = 'none'
closed = True
closed_date = <Date 2018-05-19.05:43:22.815>
closer = 'carljm'
components = ['Interpreter Core']
creation = <Date 2018-05-19.05:41:49.927>
creator = 'carljm'
dependencies = []
files = []
hgrepos = []
issue_num = 33577
keywords = []
message_count = 2.0
messages = ['317099', '317102']
nosy_count = 1.0
nosy_names = ['carljm']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue33577'
versions = ['Python 3.8']
@carljm
Copy link
Member Author

carljm commented May 19, 2018

Per Nick Coghlan in discussion on bpo-21145:

"I think it would make sense to remove the exception wrapping from the __set_name__ calls - I don't think we're improving the ease of understanding the tracebacks by converting everything to a generic RuntimeError, and we're hurting the UX of descriptor validation cases like this one."

https://github.com/python/cpython/blob/master/Objects/typeobject.c#L7263

@carljm carljm added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels May 19, 2018
@carljm
Copy link
Member Author

carljm commented May 19, 2018

Oops, duplicate of bpo-33576.

@carljm carljm closed this as completed May 19, 2018
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carljm