Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataclasses.make_dataclass does not validate fields for being valid identifiers #77717

Closed
ericvsmith opened this issue May 16, 2018 · 3 comments
Closed

dataclasses.make_dataclass does not validate fields for being valid identifiers #77717

ericvsmith opened this issue May 16, 2018 · 3 comments
Assignees
@ericvsmith
Labels
3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@ericvsmith
Copy link
Member

BPO 33536
Nosy @ericvsmith, @ned-deily, @miss-islington
PRs
  • bpo-33536: Validate make_dataclass() field names. #6906
  • [3.7] bpo-33536: Validate make_dataclass() field names. (GH-6906) #6908
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericvsmith'
closed_at = <Date 2018-05-16.18:00:50.608>
created_at = <Date 2018-05-16.12:27:58.572>
labels = ['3.8', 'type-bug', '3.7']
title = 'dataclasses.make_dataclass does not validate fields for being valid identifiers'
updated_at = <Date 2018-05-16.18:00:50.605>
user = 'https://github.com/ericvsmith'

    bugs.python.org fields:

    activity = <Date 2018-05-16.18:00:50.605>
actor = 'eric.smith'
assignee = 'eric.smith'
closed = True
closed_date = <Date 2018-05-16.18:00:50.608>
closer = 'eric.smith'
components = []
creation = <Date 2018-05-16.12:27:58.572>
creator = 'eric.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 33536
keywords = ['patch']
message_count = 3.0
messages = ['316803', '316819', '316836']
nosy_count = 3.0
nosy_names = ['eric.smith', 'ned.deily', 'miss-islington']
pr_nums = ['6906', '6908']
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33536'
versions = ['Python 3.7', 'Python 3.8']
    @ericvsmith ericvsmith added 3.7 (EOL) end of life 3.8 only security fixes labels May 16, 2018
    @ericvsmith ericvsmith self-assigned this May 16, 2018
    @ericvsmith ericvsmith added the type-bug An unexpected behavior, bug, or error label May 16, 2018
    @ericvsmith
    Copy link
    Member Author

    I'm going to make this a release blocker, since it's basically a code injection vector, although I know of no way to exploit it. The fix is easy enough.

    @ericvsmith
    Copy link
    Member Author

    New changeset 4e81296 by Eric V. Smith in branch 'master':
    bpo-33536: Validate make_dataclass() field names. (GH-6906)
    4e81296

    @miss-islington
    Copy link
    Contributor

    New changeset 6409e75 by Miss Islington (bot) in branch '3.7':
    bpo-33536: Validate make_dataclass() field names. (GH-6906)
    6409e75

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericvsmith ericvsmith

    Labels
    3.7 (EOL) end of life 3.8 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ericvsmith @miss-islington