Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect detection of information of some distributions python2 #77694

Closed
mrandybu mannequin opened this issue May 15, 2018 · 2 comments
Closed

incorrect detection of information of some distributions python2 #77694

mrandybu mannequin opened this issue May 15, 2018 · 2 comments
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@mrandybu
Copy link
Mannequin

mrandybu mannequin commented May 15, 2018

BPO 33513
Nosy @malemburg, @vstinner, @mrandybu
PRs
  • [2.7] bpo-33513: Fixed incorrect version linux detection (platform.py) #6855
    		•
    Files
  • fix-issue-33513.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-05-17.07:11:11.798>
created_at = <Date 2018-05-15.06:59:11.499>
labels = ['type-bug', 'library']
title = 'incorrect detection of information of some distributions python2'
updated_at = <Date 2018-05-17.07:11:11.797>
user = 'https://github.com/mrandybu'

    bugs.python.org fields:

    activity = <Date 2018-05-17.07:11:11.797>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-05-17.07:11:11.798>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2018-05-15.06:59:11.499>
creator = 'mrandybu'
dependencies = []
files = ['47590']
hgrepos = []
issue_num = 33513
keywords = ['patch']
message_count = 2.0
messages = ['316628', '316888']
nosy_count = 3.0
nosy_names = ['lemburg', 'vstinner', 'mrandybu']
pr_nums = ['6855']
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33513'
versions = ['Python 2.7']
    @mrandybu
    Copy link
    Mannequin Author

    mrandybu mannequin commented May 15, 2018

    In some linux distributions, the information about the distribution is incorrectly determined when the linux_distribution() method is called from the platform class. Since the information file os-release becomes a certain standard, I propose first of all to check its availability and if it is in the system - parse the information from it.

    @mrandybu mrandybu mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 15, 2018
    @vstinner
    Copy link
    Member

    Oh wow. That looks more like a new feature than a bugfix or short cleanup. I'm not sure that it's ok to do it in Python 2.

    platform.linux_distribution() is deprecated since Python 3.5 and just has been removed from Python 3.8: see bpo-28167.

    I suggest to close this issue as WONTFIX, sorry.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @serhiy-storchaka