Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclasses: repr of Field objects should use repr of each member #77676

Closed
ericvsmith opened this issue May 14, 2018 · 2 comments
Closed

dataclasses: repr of Field objects should use repr of each member #77676

ericvsmith opened this issue May 14, 2018 · 2 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@ericvsmith
Copy link
Member

BPO 33495
Nosy @ericvsmith, @ned-deily, @serhiy-storchaka
PRs
  • bpo-33495: Change dataclasses.Fields repr to use the repr of member #6798
  • [3.7] bpo-33495: Change dataclasses.Fields repr to use the repr of each of its members (GH-6798) #6806
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericvsmith'
    closed_at = <Date 2018-05-14.17:37:30.827>
    created_at = <Date 2018-05-14.12:36:16.271>
    labels = ['3.7', '3.8', 'type-bug', 'library']
    title = 'dataclasses: repr of Field objects should use repr of each member'
    updated_at = <Date 2018-05-14.17:40:31.337>
    user = 'https://github.com/ericvsmith'

    bugs.python.org fields:

    activity = <Date 2018-05-14.17:40:31.337>
    actor = 'eric.smith'
    assignee = 'eric.smith'
    closed = True
    closed_date = <Date 2018-05-14.17:37:30.827>
    closer = 'eric.smith'
    components = ['Library (Lib)']
    creation = <Date 2018-05-14.12:36:16.271>
    creator = 'eric.smith'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 33495
    keywords = ['patch']
    message_count = 2.0
    messages = ['316502', '316541']
    nosy_count = 3.0
    nosy_names = ['eric.smith', 'ned.deily', 'serhiy.storchaka']
    pr_nums = ['6798', '6806']
    priority = None
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue33495'
    versions = ['Python 3.7', 'Python 3.8']

    @ericvsmith
    Copy link
    Member Author

    This is especially true for the "type" member, since it might be a string that looks like a type name (depending on how bpo-33453 is resolved). But repr should be used for all Field members.

    @ericvsmith ericvsmith added release-blocker 3.7 (EOL) end of life 3.8 only security fixes labels May 14, 2018
    @ericvsmith ericvsmith self-assigned this May 14, 2018
    @ericvsmith ericvsmith added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 14, 2018
    @serhiy-storchaka
    Copy link
    Member

    New changeset ceb45f0 by Miss Islington (bot) in branch '3.7':
    bpo-33494: Change dataclasses.Fields repr to use the repr of each of its members (GH-6798)
    ceb45f0

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants