Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ2File(buffering=None) does not emit deprecation warning, deprecation version not documented. #77668

Closed
Carreau mannequin opened this issue May 13, 2018 · 5 comments
Closed

BZ2File(buffering=None) does not emit deprecation warning, deprecation version not documented. #77668

Carreau mannequin opened this issue May 13, 2018 · 5 comments
Labels
3.8 only security fixes

Comments

@Carreau
Copy link
Mannequin

Carreau mannequin commented May 13, 2018

BPO 33487
Nosy @gpshead, @serhiy-storchaka, @Carreau
PRs
  • bpo-33487: improve BZ2File Deprecation and documentation. #6785
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-09-11.01:16:38.044>
created_at = <Date 2018-05-13.21:42:24.294>
labels = ['3.8']
title = 'BZ2File(buffering=None) does not emit deprecation warning, deprecation version not documented.'
updated_at = <Date 2018-09-11.01:16:38.042>
user = 'https://github.com/Carreau'

    bugs.python.org fields:

    activity = <Date 2018-09-11.01:16:38.042>
actor = 'gregory.p.smith'
assignee = 'none'
closed = True
closed_date = <Date 2018-09-11.01:16:38.044>
closer = 'gregory.p.smith'
components = []
creation = <Date 2018-05-13.21:42:24.294>
creator = 'mbussonn'
dependencies = []
files = []
hgrepos = []
issue_num = 33487
keywords = ['patch']
message_count = 5.0
messages = ['316482', '316796', '316818', '324972', '324973']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'serhiy.storchaka', 'mbussonn']
pr_nums = ['6785']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue33487'
versions = ['Python 3.8']
    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 13, 2018

    BZ2File(buffering=None) should emit a deprecation warning as the argument is deprecated.

    The deprecation message and documentation should say since when it is deprecated. (AFAICT since 3.3)

    @serhiy-storchaka
    Copy link
    Member

    Actually it is ignored since 3.0.

    @Carreau
    Copy link
    Mannequin Author

    Carreau mannequin commented May 16, 2018

    Actually it is ignored since 3.0.

    My bad, I have likely misread the history. PR updated.

    @gpshead gpshead added the 3.8 only security fixes label Sep 11, 2018
    @gpshead
    Copy link
    Member

    gpshead commented Sep 11, 2018

    New changeset ffa198c by Gregory P. Smith (Matthias Bussonnier) in branch 'master':
    bpo-33487: improve BZ2File Deprecation and documentation. (GH-6785)
    ffa198c

    @gpshead
    Copy link
    Member

    gpshead commented Sep 11, 2018

    thanks!

    @gpshead gpshead closed this as completed Sep 11, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @gpshead @serhiy-storchaka