Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leak in set_symmetric_difference? #77572

Closed
lekma mannequin opened this issue Apr 30, 2018 · 10 comments
Closed

leak in set_symmetric_difference? #77572

lekma mannequin opened this issue Apr 30, 2018 · 10 comments
Assignees
@rhettinger
Labels
3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@lekma
Copy link
Mannequin

lekma mannequin commented Apr 30, 2018

BPO 33391
Nosy @rhettinger, @vstinner, @lekma, @methane, @serhiy-storchaka, @miss-islington
PRs
  • bpo-33391: fix leak in set_symmetric_difference #6670
  • bpo-33391: fix leak in set_symmetric_difference #6671
  • bpo-33391: fix leak in set_symmetric_difference #6672
  • [3.7] bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) #6690
  • [3.6] bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) #6691
  • [2.7] bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) #6692
    		•
    Files
  • setobject.c.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/rhettinger'
closed_at = <Date 2018-05-02.10:35:58.911>
created_at = <Date 2018-04-30.09:42:42.562>
labels = ['interpreter-core', 'type-bug', '3.8']
title = 'leak in set_symmetric_difference?'
updated_at = <Date 2018-05-03.02:43:22.730>
user = 'https://github.com/lekma'

    bugs.python.org fields:

    activity = <Date 2018-05-03.02:43:22.730>
actor = 'methane'
assignee = 'rhettinger'
closed = True
closed_date = <Date 2018-05-02.10:35:58.911>
closer = 'methane'
components = ['Interpreter Core']
creation = <Date 2018-04-30.09:42:42.562>
creator = 'lekma'
dependencies = []
files = ['47557']
hgrepos = []
issue_num = 33391
keywords = ['patch']
message_count = 10.0
messages = ['315945', '315947', '315951', '315988', '316058', '316062', '316064', '316066', '316094', '316101']
nosy_count = 6.0
nosy_names = ['rhettinger', 'vstinner', 'lekma', 'methane', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['6670', '6671', '6672', '6690', '6691', '6692']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33391'
versions = ['Python 3.8']
    @lekma
    Copy link
    Mannequin Author

    lekma mannequin commented Apr 30, 2018

    shouldn't otherset be decrefed before returning on error in set_symmetric_difference? if not, what am I missing?

    @lekma lekma mannequin added 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 30, 2018
    @serhiy-storchaka
    Copy link
    Member

    Good catch! Do you mind to create a pull request on GitHub?

    @serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Apr 30, 2018
    @vstinner
    Copy link
    Member

    I don't think that an unit test is needed, and I failed to write such test :-)

    @rhettinger rhettinger self-assigned this May 1, 2018
    @lekma
    Copy link
    Mannequin Author

    lekma mannequin commented May 1, 2018

    Good catch! Do you mind to create a pull request on GitHub?
    done

    @methane
    Copy link
    Member

    methane commented May 2, 2018

    New changeset 491bbed by INADA Naoki (lekma) in branch 'master':
    bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
    491bbed

    @miss-islington
    Copy link
    Contributor

    New changeset 6a56790 by Miss Islington (bot) in branch '3.7':
    bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
    6a56790

    @miss-islington
    Copy link
    Contributor

    New changeset d554699 by Miss Islington (bot) in branch '3.6':
    bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
    d554699

    @miss-islington
    Copy link
    Contributor

    New changeset 6d3d02c by Miss Islington (bot) in branch '2.7':
    bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
    6d3d02c

    @methane methane closed this as completed May 2, 2018
    @rhettinger
    Copy link
    Contributor

    I had assigned this to myself to review and apply. I would have appreciated you letting me complete that task when I had a chance to take a breath. This was a bug that I caused, so I should be the one responsible for fixing it.

    @methane
    Copy link
    Member

    methane commented May 3, 2018

    I'm sorry. I just reviewed some easy pull requests when I have time.
    I'll skip pull requests you assigned yourself next time.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @rhettinger rhettinger

    Labels
    3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @vstinner @methane @rhettinger @serhiy-storchaka @miss-islington