Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib.parse doesn't import sys #47564

Closed
mgiuca mannequin opened this issue Jul 7, 2008 · 2 comments
Closed

urllib.parse doesn't import sys #47564

mgiuca mannequin opened this issue Jul 7, 2008 · 2 comments
Labels
build The build process and cross-build stdlib Python modules in the Lib dir

Comments

@mgiuca
Copy link
Mannequin

mgiuca mannequin commented Jul 7, 2008

BPO 3314
Nosy @facundobatista
Files
  • parse.py.patch: Patch for revision 64772; commit log in comments.
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2008-07-07.18:26:32.331>
created_at = <Date 2008-07-07.14:50:29.186>
labels = ['build', 'library']
title = "urllib.parse doesn't import sys"
updated_at = <Date 2008-07-07.18:26:32.301>
user = 'https://bugs.python.org/mgiuca'

    bugs.python.org fields:

    activity = <Date 2008-07-07.18:26:32.301>
actor = 'facundobatista'
assignee = 'none'
closed = True
closed_date = <Date 2008-07-07.18:26:32.331>
closer = 'facundobatista'
components = ['Library (Lib)']
creation = <Date 2008-07-07.14:50:29.186>
creator = 'mgiuca'
dependencies = []
files = ['10843']
hgrepos = []
issue_num = 3314
keywords = ['patch']
message_count = 2.0
messages = ['69389', '69392']
nosy_count = 2.0
nosy_names = ['facundobatista', 'mgiuca']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue3314'
versions = ['Python 3.0']
    @mgiuca
    Copy link
    Mannequin Author

    mgiuca mannequin commented Jul 7, 2008

    urllib.parse doesn't import sys, which is needed on line 368, in an
    error condition for urlencode. This is only a problem when urlencode has
    a TypeError.

    Current behaviour:
>>> urllib.parse.urlencode("foo")
NameError: global name 'sys' is not defined

Desired behaviour:
>>> urllib.parse.urlencode("foo")
TypeError: not a valid non-string sequence or mapping object

    Only affects Python 3.0. (After urllib module was split up).

    Patch attached, for revision 64772.

    Commit log:

    urllib/parse.py: Added missing "import sys".

    @mgiuca mgiuca mannequin added stdlib Python modules in the Lib dir build The build process and cross-build labels Jul 7, 2008
    @facundobatista
    Copy link
    Member

    Commited in r64781, thank you!!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @facundobatista