Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoReturn missing from __all__ in typing.py #77242

Closed
aetracht mannequin opened this issue Mar 12, 2018 · 6 comments
Closed

NoReturn missing from __all__ in typing.py #77242

aetracht mannequin opened this issue Mar 12, 2018 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@aetracht
Copy link
Mannequin

aetracht mannequin commented Mar 12, 2018

BPO 33061
Nosy @gvanrossum, @ilevkivskyi, @aetracht
PRs
  • bpo-33061: Add missing 'NoReturn' to __all__ in typing.py #6127
  • [3.7] bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127) #6162
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-03-23.21:47:40.612>
created_at = <Date 2018-03-12.22:15:08.483>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'NoReturn missing from __all__ in typing.py'
updated_at = <Date 2018-03-23.21:47:40.611>
user = 'https://github.com/aetracht'

    bugs.python.org fields:

    activity = <Date 2018-03-23.21:47:40.611>
actor = 'levkivskyi'
assignee = 'none'
closed = True
closed_date = <Date 2018-03-23.21:47:40.612>
closer = 'levkivskyi'
components = ['Library (Lib)']
creation = <Date 2018-03-12.22:15:08.483>
creator = 'AllenTracht'
dependencies = []
files = []
hgrepos = []
issue_num = 33061
keywords = ['patch']
message_count = 6.0
messages = ['313962', '313963', '314111', '314170', '314335', '314336']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'levkivskyi', 'AllenTracht']
pr_nums = ['6127', '6162']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33061'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8']
    @aetracht aetracht mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Mar 12, 2018
    @ilevkivskyi
    Copy link
    Member

    This is clearly a bug. Would you like to make a PR?

    @gvanrossum
    Copy link
    Member

    Yes please! Updating __all__ is too easy to forget.

    IIRC there are scripts that check for this but they are too strict.

    @ilevkivskyi
    Copy link
    Member

    New changeset 4573820 by Ivan Levkivskyi (aetracht) in branch 'master':
    bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127)
    4573820

    @ilevkivskyi
    Copy link
    Member

    I think it makes sense to also fix this in 3.7. I will prepare a backport now.

    @ilevkivskyi
    Copy link
    Member

    New changeset ac56027 by Ivan Levkivskyi in branch '3.7':
    bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127) (bpo-6162)
    ac56027

    @ilevkivskyi
    Copy link
    Member

    The typing repo PR is not merged yet, but I am closing this here, the remainder is tracked in typing repo.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @gvanrossum @ilevkivskyi