Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEaking files in concurrent.futures.process #77237

Closed
tomMoral mannequin opened this issue Mar 12, 2018 · 6 comments
Closed

LEaking files in concurrent.futures.process #77237

tomMoral mannequin opened this issue Mar 12, 2018 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-windows topic-XML type-bug An unexpected behavior, bug, or error

Comments

@tomMoral
Copy link
Mannequin

tomMoral mannequin commented Mar 12, 2018

BPO 33056
Nosy @pfmoore, @pitrou, @tjguk, @asvetlov, @zware, @zooba, @tomMoral
PRs
  • bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor #6084
  • [3.7] bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor (GH-6084) #6092
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-03-13.09:12:21.350>
    created_at = <Date 2018-03-12.15:09:14.967>
    labels = ['expert-XML', '3.8', 'type-bug', '3.7', 'OS-windows']
    title = 'LEaking files in concurrent.futures.process'
    updated_at = <Date 2018-03-13.14:49:02.197>
    user = 'https://github.com/tomMoral'

    bugs.python.org fields:

    activity = <Date 2018-03-13.14:49:02.197>
    actor = 'steve.dower'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-03-13.09:12:21.350>
    closer = 'pitrou'
    components = ['Windows', 'XML']
    creation = <Date 2018-03-12.15:09:14.967>
    creator = 'tomMoral'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 33056
    keywords = ['patch']
    message_count = 6.0
    messages = ['313656', '313669', '313733', '313734', '313738', '313756']
    nosy_count = 7.0
    nosy_names = ['paul.moore', 'pitrou', 'tim.golden', 'asvetlov', 'zach.ware', 'steve.dower', 'tomMoral']
    pr_nums = ['6084', '6092']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue33056'
    versions = ['Python 3.7', 'Python 3.8']

    @tomMoral
    Copy link
    Mannequin Author

    tomMoral mannequin commented Mar 12, 2018

    The recent changes introduced by #3895 leaks some file descriptors (the Pipe open in _ThreadWakeup).
    They should be properly closed at shutdown.

    @tomMoral tomMoral mannequin added stdlib Python modules in the Lib dir 3.7 (EOL) end of life type-bug An unexpected behavior, bug, or error labels Mar 12, 2018
    @asvetlov
    Copy link
    Contributor

    New changeset 095ee41 by Andrew Svetlov (Thomas Moreau) in branch 'master':
    bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor (bpo-6084)
    095ee41

    @pitrou
    Copy link
    Member

    pitrou commented Mar 13, 2018

    New changeset f216cbf by Antoine Pitrou (Miss Islington (bot)) in branch '3.7':
    bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor (GH-6084) (bpo-6092)
    f216cbf

    @pitrou
    Copy link
    Member

    pitrou commented Mar 13, 2018

    Andrew: where there are multiprocessing issues, could you please nosy me so that I get a chance to review?

    Thomas: thanks for spotting this and thanks for the fix!

    @pitrou pitrou added the 3.8 only security fixes label Mar 13, 2018
    @pitrou pitrou closed this as completed Mar 13, 2018
    @asvetlov
    Copy link
    Contributor

    Antoine sorry, will do next time

    @asvetlov asvetlov added OS-windows topic-XML and removed stdlib Python modules in the Lib dir labels Mar 13, 2018
    @zooba
    Copy link
    Member

    zooba commented Mar 13, 2018

    Andrew - you can search for some module names in the nosy list to add the designated people for them. The components list doesn't include all of them (perhaps it should?).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-windows topic-XML type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants