Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: Create new tab for editor options in configdialog #77232

Closed
csabella opened this issue Mar 11, 2018 · 6 comments
Closed

IDLE: Create new tab for editor options in configdialog #77232

csabella opened this issue Mar 11, 2018 · 6 comments
Assignees
@terryjreedy
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@csabella
Copy link
Contributor

BPO 33051
Nosy @terryjreedy, @roseman, @csabella, @E-Paine
PRs
  • bpo-33051: IDLE: Separate editor options from the general tab in config #6082
    		•
    Superseder
  • bpo-40468: IDLE: configdialog tab rearrange
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2021-06-10.05:41:08.059>
created_at = <Date 2018-03-11.19:26:19.895>
labels = ['expert-IDLE', 'type-feature', '3.8', '3.9', '3.10']
title = 'IDLE: Create new tab for editor options in configdialog'
updated_at = <Date 2021-06-10.05:41:08.058>
user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2021-06-10.05:41:08.058>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2021-06-10.05:41:08.059>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-03-11.19:26:19.895>
creator = 'cheryl.sabella'
dependencies = []
files = []
hgrepos = []
issue_num = 33051
keywords = ['patch']
message_count = 6.0
messages = ['313618', '316882', '316942', '316947', '375508', '375613']
nosy_count = 4.0
nosy_names = ['terry.reedy', 'markroseman', 'cheryl.sabella', 'epaine']
pr_nums = ['6082']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '40468'
type = 'enhancement'
url = 'https://bugs.python.org/issue33051'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @csabella
    Copy link
    Contributor Author

    Split out editor options from general tab in Config Dialog.

    @csabella csabella added the 3.8 only security fixes label Mar 11, 2018
    @csabella csabella added topic-IDLE type-feature A feature request or enhancement labels Mar 11, 2018
    @terryjreedy
    Copy link
    Member

    I expected that this would be needed eventually. Any particular reason why now?

    @csabella
    Copy link
    Contributor Author

    Yes, I thought it would be good to have this before bpo-33046.

    @terryjreedy
    Copy link
    Member

    A new option would (maybe) apply to saving the shell also. (Something to discuss there.)

    @E-Paine
    Copy link
    Mannequin

    E-Paine mannequin commented Aug 16, 2020

    Thank you Cheryl for linking this issue on bpo-40468 (I didn't find this when researching for existing issues). I have briefly tested the PR and it seems perfect, though seeing init_validators made me think we should possibly have an ABC for the tab pages. This would be a separate issue, but I think there would be three main advantages:

    1. We could enforce a more standard naming of page methods (create_page_* would become create_page and be called by the parent, for example)
    2. We could share methods like init_validators (which would preferably be part of the class but I appreciate the need to move it in this PR)
    3. We can also potentially remove the example TabPage as the ABC would serve as its own example

    Back to this issue, I didn't scrutinise it but the PR looks good and the "result" (user-facing) is exactly as I would propose based on bpo-40468.

    @E-Paine E-Paine mannequin added 3.9 only security fixes 3.10 only security fixes labels Aug 16, 2020
    @csabella
    Copy link
    Contributor Author

    @epaine, thank you for taking a look at that PR and for your feedback. I agree with you that the changes can still be taken further than we've already done. init_validators was added after the initial refactoring and I'm not sure if we've gone back to it to really use it or any other input validators. There's another bug issue (bpo-31306) that addresses the validation on configdialog, so maybe your ideas can be incorporated with that issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @csabella