Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3.7 and 3.8 Windows and macOS installer builds to tcl/tk 8.6.8 #77082

Closed
terryjreedy opened this issue Feb 21, 2018 · 17 comments
Closed

Update 3.7 and 3.8 Windows and macOS installer builds to tcl/tk 8.6.8 #77082

terryjreedy opened this issue Feb 21, 2018 · 17 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-mac OS-windows topic-tkinter

Comments

@terryjreedy
Copy link
Member

BPO 32901
Nosy @terryjreedy, @pfmoore, @ronaldoussoren, @tjguk, @ned-deily, @zware, @serhiy-storchaka, @zooba, @csabella, @miss-islington
PRs
  • bpo-32901: Update Tcl and Tk versions to 8.6.8 #5823
  • [3.7] bpo-32901: Update Tcl and Tk versions to 8.6.8 (GH-5823) #5831
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2018-02-27.22:53:23.129>
created_at = <Date 2018-02-21.21:26:55.004>
labels = ['OS-mac', '3.8', '3.7', 'expert-tkinter', 'OS-windows']
title = 'Update 3.7 and 3.8 Windows and macOS installer builds to tcl/tk 8.6.8'
updated_at = <Date 2018-02-27.22:53:23.128>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2018-02-27.22:53:23.128>
actor = 'ned.deily'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2018-02-27.22:53:23.129>
closer = 'ned.deily'
components = ['macOS', 'Tkinter', 'Windows']
creation = <Date 2018-02-21.21:26:55.004>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 32901
keywords = ['patch']
message_count = 17.0
messages = ['312512', '312514', '312577', '312583', '312584', '312586', '312591', '312594', '312598', '312639', '312640', '312643', '312668', '312669', '313030', '313031', '313032']
nosy_count = 10.0
nosy_names = ['terry.reedy', 'paul.moore', 'ronaldoussoren', 'tim.golden', 'ned.deily', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'cheryl.sabella', 'miss-islington']
pr_nums = ['5823', '5831']
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue32901'
versions = ['Python 3.7', 'Python 3.8']
    @terryjreedy
    Copy link
    Member Author

    This should be done ASAP for most testing.

    MacOS 64bit 3.7.0b1 links to 8.6.7. Whether that should be upgraded to 8.6.8 is up to Ned. I raised question on bpo-15663.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Feb 21, 2018
    @zware
    Copy link
    Member

    zware commented Feb 21, 2018

    This is on Steve these days due to the binary signing.

    @zooba
    Copy link
    Member

    zooba commented Feb 22, 2018

    Yay, more work...

    (btw Zach, nothing stopping you from putting the sources up for me :) I just need to hit the buttons to make the build.)

    @ned-deily
    Copy link
    Member

    Yeah, we should do that for the macOS installers as well.

    @ned-deily ned-deily changed the title Update Windows 3.7/8 builds to tcl/tk 8.6.8 Update 3.7 and 3.8 Windows and macOS installer builds to tcl/tk 8.6.8 Feb 22, 2018
    @zware
    Copy link
    Member

    zware commented Feb 22, 2018

    True :). I'll get the sources up if I get a chance to do it before you do.

    (Anyone else can feel free to take a crack at it as well, see https://github.com/python/cpython-source-deps/blob/master/README.rst for instructions that should hopefully work :))

    @csabella
    Copy link
    Contributor

    I'll give it a shot. :-)

    @zooba
    Copy link
    Member

    zooba commented Feb 22, 2018

    I'm already most of the way through doing the sources this time - just running into ssh/GitHub troubles getting them online.

    @zooba
    Copy link
    Member

    zooba commented Feb 22, 2018

    Still working on this - X11 and the WinSDK aren't playing nicely together. I might need a special build configuration to build this, or to submit fixes (and apply patches) to Tk.

    @terryjreedy
    Copy link
    Member Author

    Is "this will only be useful on Windows," in the source-deps readme still true? It appears that the tcl/tk tar.gz source is meant for Mac also. (IE, has Xcode project files.)
    https://tcl.tk/software/tcltk/download.html

    Looking ahead, there is an 8.7a1 release. I am hoping that 8.7 will be available for our 3.8, as it should include a rewritten Text widget that, among other things, will fix the slow long lines problem. Do we wait for 8.7 final or do we start testing and, if necessary, adapting _tkinter and tkinter with, say, their .b1?

    @zooba
    Copy link
    Member

    zooba commented Feb 23, 2018

    New changeset efa6c76 by Steve Dower in branch 'master':
    bpo-32901: Update Tcl and Tk versions to 8.6.8 (GH-5823)
    efa6c76

    @zooba
    Copy link
    Member

    zooba commented Feb 23, 2018

    The sources are just the original sources, so they could be useful on other platforms too.

    The build on cpython-bin-deps is obviously only useful on Windows.

    @miss-islington
    Copy link
    Contributor

    New changeset 74b7364 by Miss Islington (bot) in branch '3.7':
    bpo-32901: Update Tcl and Tk versions to 8.6.8 (GH-5823)
    74b7364

    @zooba
    Copy link
    Member

    zooba commented Feb 23, 2018

    Windows is complete - leaving this open for Ned to resolve when the Mac installers are done.

    @terryjreedy
    Copy link
    Member Author

    New build with 8.6.8 seems to work fine on my machine. Thanks.

    I noticed that 'fetching tcl/tk 8.6.8' downloaded a pre-built binary instead of sources to build on my machine. Nice.

    @ned-deily
    Copy link
    Member

    New changeset 9189e95 by Ned Deily in branch 'master':
    bpo-32901: update macOS 10.9+ installer to Tcl/Tk 8.6.8
    9189e95

    @ned-deily
    Copy link
    Member

    New changeset a7edca7 by Ned Deily in branch '3.7':
    bpo-32901: update macOS 10.9+ installer to Tcl/Tk 8.6.8
    a7edca7

    @ned-deily
    Copy link
    Member

    Terry:

    Is "this will only be useful on Windows," in the source-deps readme still true? It appears that the tcl/tk tar.gz source is meant for Mac also.

    The macOS installer builds do not use the cpython-source-deps repo.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-mac OS-windows topic-tkinter
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    6 participants
    @zooba @ned-deily @zware @terryjreedy @csabella @miss-islington