Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.dup2() tests dup3() availability on each call #77040

Closed
izbyshev mannequin opened this issue Feb 16, 2018 · 4 comments
Closed

os.dup2() tests dup3() availability on each call #77040

izbyshev mannequin opened this issue Feb 16, 2018 · 4 comments
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@izbyshev
Copy link
Mannequin

izbyshev mannequin commented Feb 16, 2018

BPO 32859
Nosy @vstinner, @benjaminp, @izbyshev
PRs
  • bpo-32859: Don't retry dup3() if it is not available at runtime #5708
  • [3.7] closes bpo-32859: Don't retry dup3() if it is not available at runtime (GH-5708) #5768
  • [3.6] closes bpo-32859: Don't retry dup3() if it is not available at runtime (GH-5708) #5769
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-02-20.07:25:54.407>
created_at = <Date 2018-02-16.23:10:17.305>
labels = ['extension-modules', '3.7', 'library', 'performance']
title = 'os.dup2() tests dup3() availability on each call'
updated_at = <Date 2018-02-21.05:21:14.552>
user = 'https://github.com/izbyshev'

    bugs.python.org fields:

    activity = <Date 2018-02-21.05:21:14.552>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2018-02-20.07:25:54.407>
closer = 'benjamin.peterson'
components = ['Extension Modules', 'Library (Lib)']
creation = <Date 2018-02-16.23:10:17.305>
creator = 'izbyshev'
dependencies = []
files = []
hgrepos = []
issue_num = 32859
keywords = ['patch']
message_count = 4.0
messages = ['312256', '312400', '312401', '312460']
nosy_count = 3.0
nosy_names = ['vstinner', 'benjamin.peterson', 'izbyshev']
pr_nums = ['5708', '5768', '5769']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue32859'
versions = ['Python 3.6', 'Python 3.7']
    @izbyshev
    Copy link
    Mannequin Author

    izbyshev mannequin commented Feb 16, 2018

    os.dup2() tests for dup3() system call availability at runtime, but doesn't remember the result across calls, repeating the test on each call with inheritable=False even if the test fails.

    Judging by the code, 'dup3_works' was intended to be static (the first time its value is checked it's always an initial one).

    @izbyshev izbyshev mannequin added 3.7 (EOL) end of life extension-modules C modules in the Modules dir stdlib Python modules in the Lib dir performance Performance or resource usage labels Feb 16, 2018
    @benjaminp
    Copy link
    Contributor

    New changeset b3caf38 by Benjamin Peterson (Alexey Izbyshev) in branch 'master':
    closes bpo-32859: Don't retry dup3() if it is not available at runtime (GH-5708)
    b3caf38

    @benjaminp
    Copy link
    Contributor

    New changeset bab4fe3 by Benjamin Peterson (Miss Islington (bot)) in branch '3.7':
    closes bpo-32859: Don't retry dup3() if it is not available at runtime (GH-5708)
    bab4fe3

    @benjaminp
    Copy link
    Contributor

    New changeset 16de2a9 by Benjamin Peterson (Miss Islington (bot)) in branch '3.6':
    closes bpo-32859: Don't retry dup3() if it is not available at runtime (GH-5708)
    16de2a9

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir performance Performance or resource usage stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @benjaminp