Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Add docstrings and tests for codecontext #77012

Closed
csabella opened this issue Feb 12, 2018 · 8 comments
Closed

IDLE: Add docstrings and tests for codecontext #77012

csabella opened this issue Feb 12, 2018 · 8 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@csabella
Copy link
Contributor

BPO 32831
Nosy @terryjreedy, @csabella, @miss-islington
PRs
  • bpo-32831: IDLE: Add docstrings and tests for codecontext #5638
  • [3.7] bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638) #6988
  • [3.6] bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638) #6989
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
    closed_at = <Date 2018-05-20.00:12:44.096>
    created_at = <Date 2018-02-12.13:08:11.671>
    labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
    title = 'IDLE: Add docstrings and tests for codecontext'
    updated_at = <Date 2018-05-23.05:23:16.371>
    user = 'https://github.com/csabella'

    bugs.python.org fields:

    activity = <Date 2018-05-23.05:23:16.371>
    actor = 'terry.reedy'
    assignee = 'terry.reedy'
    closed = True
    closed_date = <Date 2018-05-20.00:12:44.096>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2018-02-12.13:08:11.671>
    creator = 'cheryl.sabella'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32831
    keywords = ['patch']
    message_count = 8.0
    messages = ['312046', '316987', '316992', '317134', '317136', '317137', '317144', '317359']
    nosy_count = 3.0
    nosy_names = ['terry.reedy', 'cheryl.sabella', 'miss-islington']
    pr_nums = ['5638', '6988', '6989']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32831'
    versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

    @csabella
    Copy link
    Contributor Author

    Add docstrings and tests for codecontext.py.

    @csabella csabella added the 3.8 only security fixes label Feb 12, 2018
    @csabella csabella added topic-IDLE type-feature A feature request or enhancement labels Feb 12, 2018
    @terryjreedy
    Copy link
    Member

    After this is merged, we should immediately add 'async' to the list of block openers.

    With complete tests, we can more confidently cleanup the code a bit, as well as change behavior. The fourth field of info tuples, block keyword, is never used as part of info tuples. (It is used before being added in get_context.)

    @terryjreedy terryjreedy added the 3.7 (EOL) end of life label May 17, 2018
    @terryjreedy
    Copy link
    Member

    Because BLOCKOPENERS is sufficiently distant from the changes for this issue, I will add 'async' now, without tests, in bpo-33564.

    Some of my comments for this issue are ideas for future changes in codecontext.py.

    @terryjreedy
    Copy link
    Member

    New changeset 654038d by Terry Jan Reedy (Cheryl Sabella) in branch 'master':
    bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638)
    654038d

    @miss-islington
    Copy link
    Contributor

    New changeset 83aedc4 by Miss Islington (bot) in branch '3.6':
    bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638)
    83aedc4

    @miss-islington
    Copy link
    Contributor

    New changeset 0efa135 by Miss Islington (bot) in branch '3.7':
    bpo-32831: IDLE: Add docstrings and tests for codecontext (GH-5638)
    0efa135

    @terryjreedy
    Copy link
    Member

    Thanks for the good set of tests.

    @terryjreedy
    Copy link
    Member

    If you are following up with a new patch that includes code changes, make a new issue. In the opening message, please briefly list the mini-issues fixed so I can refer changes to purposes. Perhaps something like

    • getspacesfirstword - function and param1 names
      ...

    List the new issue as a dependency of new 'improve code context' bpo-33610 that addresses point 2.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants