Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smtplib: duplicated debug message #76974

Closed
qingyunha mannequin opened this issue Feb 8, 2018 · 7 comments
Closed

smtplib: duplicated debug message #76974

qingyunha mannequin opened this issue Feb 8, 2018 · 7 comments
Labels
3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@qingyunha
Copy link
Mannequin

qingyunha mannequin commented Feb 8, 2018

BPO 32793
Nosy @giampaolo, @maxking, @qingyunha, @corona10, @ZackerySpytz, @miss-islington, @iritkatriel
PRs
  • bpo-32793: Fix a duplicate debug message in smtplib #15341
  • [3.8] bpo-32793: Fix a duplicate debug message in smtplib (GH-15341) #22683
    		•
    Files
  • smtp.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-10-13.15:19:46.741>
created_at = <Date 2018-02-08.09:05:18.866>
labels = ['3.8', 'type-bug', 'library', '3.9']
title = 'smtplib: duplicated debug message'
updated_at = <Date 2020-10-13.15:19:46.740>
user = 'https://github.com/qingyunha'

    bugs.python.org fields:

    activity = <Date 2020-10-13.15:19:46.740>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-13.15:19:46.741>
closer = 'corona10'
components = ['Library (Lib)']
creation = <Date 2018-02-08.09:05:18.866>
creator = 'qingyunha'
dependencies = []
files = ['47428']
hgrepos = []
issue_num = 32793
keywords = ['patch']
message_count = 7.0
messages = ['311818', '350026', '350027', '378397', '378559', '378564', '378565']
nosy_count = 7.0
nosy_names = ['giampaolo.rodola', 'maxking', 'qingyunha', 'corona10', 'ZackerySpytz', 'miss-islington', 'iritkatriel']
pr_nums = ['15341', '22683']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32793'
versions = ['Python 3.8', 'Python 3.9']
    @qingyunha
    Copy link
    Mannequin Author

    qingyunha mannequin commented Feb 8, 2018 

                if self.debuglevel > 0:
                self._print_debug('connect:', (host, port))

    The above both in _get_socket and connect method, and connect also invoke _get_socket.

    @qingyunha qingyunha mannequin added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir labels Feb 8, 2018
    @ZackerySpytz ZackerySpytz mannequin added 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Aug 20, 2019
    @maxking
    Copy link
    Contributor

    maxking commented Aug 20, 2019

    Removing 2.7 which only accepts security patches.

    @miss-islington
    Copy link
    Contributor

    New changeset 46a7564 by Miss Islington (bot) (Zackery Spytz) in branch 'master':
    bpo-32793: Fix a duplicate debug message in smtplib (GH-15341)
    46a7564

    @iritkatriel
    Copy link
    Member

    Does this need to be backported to 3.8/3.7?

    @corona10
    Copy link
    Member

    3.7 only can be applied security fix.

    https://cpython-devguide.readthedocs.io/#branchstatus

    @corona10 corona10 removed the 3.7 (EOL) end of life label Oct 13, 2020
    @corona10
    Copy link
    Member

    New changeset 76b1913 by Dong-hee Na in branch '3.8':
    [3.8] bpo-32793: Fix a duplicate debug message in smtplib (GH-15341) (GH-22683)
    76b1913

    @corona10
    Copy link
    Member

    @ZackerySpytz Thank you for work :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @maxking @iritkatriel @corona10 @miss-islington