Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install PowerShell activation scripts for venv for all platforms #76899

Closed
brettcannon opened this issue Jan 30, 2018 · 4 comments
Closed

Install PowerShell activation scripts for venv for all platforms #76899

brettcannon opened this issue Jan 30, 2018 · 4 comments
Assignees
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@brettcannon
Copy link
Member

BPO 32718
Nosy @brettcannon, @vsajip, @miss-islington
PRs
  • bpo-32718: Make Activate.ps1 for venv cross-platform and available on all platforms #9321
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
    closed_at = <Date 2018-09-21.22:37:49.955>
    created_at = <Date 2018-01-30.00:54:56.194>
    labels = ['3.8', 'type-feature', 'library']
    title = 'Install PowerShell activation scripts for venv for all platforms'
    updated_at = <Date 2018-09-21.22:37:49.954>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2018-09-21.22:37:49.954>
    actor = 'brett.cannon'
    assignee = 'brett.cannon'
    closed = True
    closed_date = <Date 2018-09-21.22:37:49.955>
    closer = 'brett.cannon'
    components = ['Library (Lib)']
    creation = <Date 2018-01-30.00:54:56.194>
    creator = 'brett.cannon'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32718
    keywords = ['patch']
    message_count = 4.0
    messages = ['311206', '319108', '319677', '326051']
    nosy_count = 3.0
    nosy_names = ['brett.cannon', 'vinay.sajip', 'miss-islington']
    pr_nums = ['9321']
    priority = 'low'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32718'
    versions = ['Python 3.8']

    @brettcannon
    Copy link
    Member Author

    Thanks to https://github.com/PowerShell/PowerShell, PowerShell Core is cross-platform. That suggests that the Activate.ps1 file for venv should be moved to the common/ directory instead of existing only in the nt/ directory.

    @brettcannon brettcannon added 3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Jan 30, 2018
    @brettcannon brettcannon self-assigned this Apr 27, 2018
    @brettcannon
    Copy link
    Member Author

    Looks like there is some PowerShell Core compatibility issues to work through first. Primarily the prompt seems the venv prompt additions show up twice but then disappear if you arrow up. There is also an issue of path separators needing to be updated appropriately according to the OS.

    @brettcannon
    Copy link
    Member Author

    The prompt issues I was having are fixed in PowerShell 6.1.0-preview3, so as soon at 6.1.0 reaches final I will start working on this again.

    @miss-islington
    Copy link
    Contributor

    New changeset d64ee1a by Miss Islington (bot) (Brett Cannon) in branch 'master':
    bpo-32718: Make Activate.ps1 for venv cross-platform and available on all platforms (GH-9321)
    d64ee1a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants