Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee that Python preserves the order of kwonly parameters #76878

Closed
larryhastings opened this issue Jan 28, 2018 · 4 comments
Closed

Guarantee that Python preserves the order of kwonly parameters #76878

larryhastings opened this issue Jan 28, 2018 · 4 comments
Assignees
@larryhastings
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@larryhastings
Copy link
Contributor

BPO 32697
Nosy @gpshead, @larryhastings, @ericvsmith, @ericsnowcurrently, @1st1
PRs
  • bpo-32697: Definition order of kwonly params is now preserved. #5391
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/larryhastings'
closed_at = <Date 2018-01-28.19:16:35.728>
created_at = <Date 2018-01-28.17:48:42.404>
labels = ['interpreter-core', 'type-feature', '3.7']
title = 'Guarantee that Python preserves the order of kwonly parameters'
updated_at = <Date 2018-01-28.19:22:35.626>
user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2018-01-28.19:22:35.626>
actor = 'yselivanov'
assignee = 'larry'
closed = True
closed_date = <Date 2018-01-28.19:16:35.728>
closer = 'larry'
components = ['Interpreter Core']
creation = <Date 2018-01-28.17:48:42.404>
creator = 'larry'
dependencies = []
files = []
hgrepos = []
issue_num = 32697
keywords = ['patch']
message_count = 4.0
messages = ['310975', '310982', '310984', '310985']
nosy_count = 5.0
nosy_names = ['gregory.p.smith', 'larry', 'eric.smith', 'eric.snow', 'yselivanov']
pr_nums = ['5391']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32697'
versions = ['Python 3.7']
    @larryhastings
    Copy link
    Contributor Author

    Following on from the "Can Python guarantee the order of keyword-only parameters?", here's a patch to enforce that guarantee. It adds documentation that makes the guarantee, and adds tests that make at least a passable attempt at testing that it's true.

    I nosied everybody who +1'd my original proposal in python-dev, because I'm looking for someone to review the patch. Beta 1 gets tagged on Sunday, so can someone rubber-stamp this today?

    @larryhastings larryhastings added the 3.7 (EOL) end of life label Jan 28, 2018
    @larryhastings larryhastings self-assigned this Jan 28, 2018
    @larryhastings larryhastings added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Jan 28, 2018
    @larryhastings
    Copy link
    Contributor Author

    New changeset f36ba12 by larryhastings in branch 'master':
    bpo-32697: Definition order of kwonly params is now guaranteed preserved. (bpo-5391)
    f36ba12

    @larryhastings
    Copy link
    Contributor Author

    Thanks for the quick turnaround reviews! Today we've all collectively made Python a better programming language.

    @1st1
    Copy link
    Member

    1st1 commented Jan 28, 2018

    Today we've all collectively made Python a better programming language.

    Literally can't stop doing that for some reason... :)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @larryhastings larryhastings

    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @1st1 @larryhastings