Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMTPUTF8SimTests are not actually being run #76844

Closed
chason mannequin opened this issue Jan 25, 2018 · 5 comments
Closed

SMTPUTF8SimTests are not actually being run #76844

chason mannequin opened this issue Jan 25, 2018 · 5 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@chason
Copy link
Mannequin

chason mannequin commented Jan 25, 2018

BPO 32663
Nosy @bitdancer, @segevfiner, @chason
PRs
  • bpo-32663 Make SMTPUTF8SimTests run #5314
  • [3.6] bpo-32663 Make SMTPUTF8SimTests run (GH-5314) #8470
  • [3.7] bpo-32663 Make SMTPUTF8SimTests run (GH-5314) #8471
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-07-26.14:03:43.724>
created_at = <Date 2018-01-25.08:41:56.156>
labels = ['type-bug', 'tests']
title = 'SMTPUTF8SimTests are not actually being run'
updated_at = <Date 2018-07-26.14:03:43.722>
user = 'https://github.com/chason'

    bugs.python.org fields:

    activity = <Date 2018-07-26.14:03:43.722>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-26.14:03:43.724>
closer = 'r.david.murray'
components = ['Tests']
creation = <Date 2018-01-25.08:41:56.156>
creator = 'chason.chaffin'
dependencies = []
files = []
hgrepos = []
issue_num = 32663
keywords = ['patch']
message_count = 5.0
messages = ['310664', '322387', '322424', '322425', '322426']
nosy_count = 3.0
nosy_names = ['r.david.murray', 'Segev Finer', 'chason.chaffin']
pr_nums = ['5314', '8470', '8471']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32663'
versions = []
    @chason
    Copy link
    Mannequin Author

    chason mannequin commented Jan 25, 2018

    In the tests for smtplib, the suite of tests for SMTPUTF8SimTests (added by bpo-24218) are not actually being run. This is troublesome in particular, because the test test_send_message_error_on_non_ascii_addrs_if_no_smtputf8 calls assertRaises incorrectly and thus fails.

    @chason chason mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Jan 25, 2018
    @bitdancer
    Copy link
    Member

    New changeset 48ed88a by R. David Murray (chason) in branch 'master':
    bpo-32663 Make SMTPUTF8SimTests run (bpo-5314)
    48ed88a

    @bitdancer
    Copy link
    Member

    New changeset 89352b0 by R. David Murray (Miss Islington (bot)) in branch '3.7':
    bpo-32663 Make SMTPUTF8SimTests run (GH-5314) (bpo-8471)
    89352b0

    @bitdancer
    Copy link
    Member

    New changeset cecbe0a by R. David Murray (Miss Islington (bot)) in branch '3.6':
    bpo-32663 Make SMTPUTF8SimTests run (GH-5314) (bpo-8470)
    cecbe0a

    @bitdancer
    Copy link
    Member

    Thanks, Chason.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @bitdancer