Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug support for native coroutines is broken #76831

Closed
asvetlov opened this issue Jan 24, 2018 · 7 comments
Closed

Debug support for native coroutines is broken #76831

asvetlov opened this issue Jan 24, 2018 · 7 comments
Labels
3.7 (EOL) end of life type-feature A feature request or enhancement

Comments

@asvetlov
Copy link
Contributor

BPO 32650
Nosy @njsmith, @asvetlov, @1st1
PRs
  • bpo-32650: Add native coroutine support to bdb when stepping over line #5400
  • [3.6] bpo-32650: Add native coroutine support to bdb when stepping over line (GH-5400) #5402
  • bpo-32650 Add support for async generators and more test for coroutines in pdb  #5403
  • bpo-32650: Add an asyncgen pdb test #5406
  • [3.6] bpo-32650 Add support for async generators and more test for coroutines in pdb (GH-5403) #5411
  • [3.6] bpo-32650: Add an asyncgen pdb test (GH-5406) #5419
  • bpo-32650: Add a test for pdb until command in coroutine #5427
  • [3.6] bpo-32650: Add a test for pdb until command in coroutine (GH-5427) #5428
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-01-29.03:44:15.548>
created_at = <Date 2018-01-24.15:08:43.532>
labels = ['type-feature', '3.7']
title = 'Debug support for native coroutines is broken'
updated_at = <Date 2018-01-29.14:22:03.631>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2018-01-29.14:22:03.631>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-29.03:44:15.548>
closer = 'yselivanov'
components = []
creation = <Date 2018-01-24.15:08:43.532>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 32650
keywords = ['patch']
message_count = 7.0
messages = ['310600', '311037', '311039', '311047', '311063', '311073', '311088']
nosy_count = 3.0
nosy_names = ['njs', 'asvetlov', 'yselivanov']
pr_nums = ['5400', '5402', '5403', '5406', '5411', '5419', '5427', '5428']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32650'
versions = ['Python 3.6', 'Python 3.7']
    @asvetlov
    Copy link
    Contributor Author

    pdb (and other Python debuggers) are built on top of bdb.py module.

    The module has a support for stepping to next line in function (next command).

    The command checks frame flags and do extra steps if the flags contains CO_GENERATOR.

    But CO_COROUTINE is not supported, it leads to stepping into a native coroutine instead of expecting stepping over.

    The patch should be relative simple: just add a check for CO_COROUTINE along with CO_GENERATOR everywhere.

    @asvetlov asvetlov added the 3.7 (EOL) end of life label Jan 24, 2018
    @asvetlov
    Copy link
    Contributor Author

    New changeset 4687702 by Andrew Svetlov (Pablo Galindo) in branch 'master':
    bpo-32650: Add native coroutine support to bdb when stepping over line (GH-5400)
    4687702

    @1st1
    Copy link
    Member

    1st1 commented Jan 29, 2018

    New changeset c7ab581 by Yury Selivanov (Pablo Galindo) in branch 'master':
    bpo-32650 Add support for async generators and more test for coroutines in pdb (bpo-5403)
    c7ab581

    @1st1
    Copy link
    Member

    1st1 commented Jan 29, 2018

    New changeset 9ee1bf9 by Yury Selivanov in branch 'master':
    bpo-32650: Add an asyncgen pdb test (bpo-5406)
    9ee1bf9

    @1st1 1st1 closed this as completed Jan 29, 2018
    @1st1 1st1 added the type-feature A feature request or enhancement label Jan 29, 2018
    @asvetlov
    Copy link
    Contributor Author

    New changeset 543ec00 by Andrew Svetlov (Miss Islington (bot)) in branch '3.6':
    bpo-32650: Add native coroutine support to bdb when stepping over line (GH-5400) (bpo-5402)
    543ec00

    @asvetlov
    Copy link
    Contributor Author

    New changeset 3cfb84c by Andrew Svetlov in branch '3.6':
    [3.6] bpo-32650 Add support for async generators and more test for coroutines in pdb (GH-5403). (bpo-5411)
    3cfb84c

    @asvetlov
    Copy link
    Contributor Author

    New changeset d9c743b by Andrew Svetlov (Miss Islington (bot)) in branch '3.6':
    bpo-32650: Add an asyncgen pdb test (GH-5406) (bpo-5419)
    d9c743b

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @1st1 @asvetlov