Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Task._step, Task._wakeup and Future._schedule_callback methods private #76824

Closed
1st1 opened this issue Jan 24, 2018 · 2 comments
Closed

Make Task._step, Task._wakeup and Future._schedule_callback methods private #76824

1st1 opened this issue Jan 24, 2018 · 2 comments
Labels
3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Jan 24, 2018

BPO 32643
Nosy @asvetlov, @cjerdonek, @1st1
PRs
  • bpo-32643: Drop support for a few private Task and Future APIs. #5293
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-01-24.16:31:19.162>
created_at = <Date 2018-01-24.05:32:19.660>
labels = ['type-feature', '3.7', 'expert-asyncio']
title = 'Make Task._step, Task._wakeup and Future._schedule_callback methods private'
updated_at = <Date 2018-01-24.16:31:19.161>
user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2018-01-24.16:31:19.161>
actor = 'yselivanov'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-24.16:31:19.162>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2018-01-24.05:32:19.660>
creator = 'yselivanov'
dependencies = []
files = []
hgrepos = []
issue_num = 32643
keywords = ['patch']
message_count = 2.0
messages = ['310561', '310611']
nosy_count = 3.0
nosy_names = ['asvetlov', 'chris.jerdonek', 'yselivanov']
pr_nums = ['5293']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32643'
versions = ['Python 3.7']
    @1st1
    Copy link
    Member Author

    1st1 commented Jan 24, 2018

    I propose to drop support for overloading Task._step, Task._wakeup, and Future._schedule_callbacks.

    This makes the implementation easier for us to maintain and optimize. It also makes it easier for alternative asyncio event loops and interops with other async frameworks.

    @1st1 1st1 added 3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement labels Jan 24, 2018
    @1st1
    Copy link
    Member Author

    1st1 commented Jan 24, 2018

    New changeset 22feeb8 by Yury Selivanov in branch 'master':
    bpo-32643: Drop support for a few private Task and Future APIs. (bpo-5293)
    22feeb8

    @1st1 1st1 closed this as completed Jan 24, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @1st1