Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement loop.sendfile #76803

Closed
asvetlov opened this issue Jan 22, 2018 · 19 comments
Closed

Implement loop.sendfile #76803

asvetlov opened this issue Jan 22, 2018 · 19 comments
Labels
3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement

Comments

@asvetlov
Copy link
Contributor

BPO 32622
Nosy @vstinner, @giampaolo, @asvetlov, @1st1, @miss-islington
PRs
  • bpo-32622: Implement loop.sendfile() #5271
  • bpo-32622: Enforce sendfile fallback policy for FALLBACK transports #5364
  • bpo-32622: Fix tests if Python compiled without SSL #5367
  • bpo-32622: Fix AbstractEventLoop.sendfile signature in documentation. #5368
  • bpo-32622: Normalize ENOTCONN to ConnectionError on macOS #5369
  • bpo-32622: Native sendfile on windows #5565
  • [3.7] bpo-32622: Native sendfile on windows (GH-5565) #5890
  • bpo-33353: test_asyncio uses smaller sendfile data #7083
  • [3.7] bpo-33353: test_asyncio uses smaller sendfile data (GH-7083) #7084
  • bpo-33353: test_asyncio set SO_SNDBUF after connect #7086
  • bpo-35682: Fix _ProactorBasePipeTransport._force_close() #11462
  • [3.7] bpo-35682: Fix _ProactorBasePipeTransport._force_close() (GH-11462) #11463
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-05-29.15:15:47.114>
created_at = <Date 2018-01-22.15:21:57.962>
labels = ['type-feature', '3.7', 'expert-asyncio']
title = 'Implement loop.sendfile'
updated_at = <Date 2019-01-08.02:15:28.412>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2019-01-08.02:15:28.412>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2018-05-29.15:15:47.114>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2018-01-22.15:21:57.962>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 32622
keywords = ['patch']
message_count = 19.0
messages = ['310880', '310887', '310891', '310892', '310893', '310896', '310897', '311105', '311108', '311114', '311123', '312820', '312822', '317471', '317484', '317490', '318043', '333196', '333201']
nosy_count = 5.0
nosy_names = ['vstinner', 'giampaolo.rodola', 'asvetlov', 'yselivanov', 'miss-islington']
pr_nums = ['5271', '5364', '5367', '5368', '5369', '5565', '5890', '7083', '7084', '7086', '11462', '11463']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32622'
versions = ['Python 3.7']
    @asvetlov
    Copy link
    Contributor Author

    New changeset 7c68407 by Andrew Svetlov in branch 'master':
    bpo-32622: Implement loop.sendfile() (bpo-5271)
    7c68407

    @1st1 1st1 closed this as completed Jan 27, 2018
    @1st1 1st1 added the type-feature A feature request or enhancement label Jan 27, 2018
    @1st1
    Copy link
    Member

    1st1 commented Jan 27, 2018

    New changeset b1a6ac4 by Yury Selivanov in branch 'master':
    bpo-32622: Enforce sendfile fallback policy for FALLBACK transports (bpo-5364)
    b1a6ac4

    @vstinner
    Copy link
    Member

    s390x Debian 3.x buildbot failed:
    http://buildbot.python.org/all/#/builders/13/builds/601

    Exmaple:

    ======================================================================
    ERROR: test_sendfile_ssl_pre_and_post_data (test.test_asyncio.test_events.SelectEventLoopTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_asyncio/test_events.py", line 2277, in test_sendfile_ssl_pre_and_post_data
    srv_proto, cli_proto = self.prepare(is_ssl=True)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_asyncio/test_events.py", line 2136, in prepare
    srv_ctx = test_utils.simple_server_sslcontext()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_asyncio/utils.py", line 73, in simple_server_sslcontext
    server_context = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER)
AttributeError: 'NoneType' object has no attribute 'SSLContext'

    @vstinner vstinner reopened this Jan 27, 2018
    @1st1
    Copy link
    Member

    1st1 commented Jan 27, 2018

    AttributeError: 'NoneType' object has no attribute 'SSLContext'

    We've just pushed a fix for this.

    @1st1
    Copy link
    Member

    1st1 commented Jan 27, 2018

    New changeset ee72ac0 by Yury Selivanov (Elvis Pranskevichus) in branch 'master':
    bpo-32622: Fix AbstractEventLoop.sendfile signature in documentation. (GH-5368)
    ee72ac0

    @1st1
    Copy link
    Member

    1st1 commented Jan 27, 2018

    New changeset 2a2247c by Yury Selivanov in branch 'master':
    bpo-32622: Normalize ENOTCONN to ConnectionError on macOS (GH-5369)
    2a2247c

    @1st1
    Copy link
    Member

    1st1 commented Jan 27, 2018

    I think we've fixed everything. Closing this for now, Victor please reopen if buildbots misbehave.

    @1st1 1st1 closed this as completed Jan 27, 2018
    @vstinner
    Copy link
    Member

    New asyncio sendfile tests fail on many buildbots. See:
    https://bugs.python.org/issue32645#msg311101

    @vstinner vstinner reopened this Jan 29, 2018
    @asvetlov
    Copy link
    Contributor Author

    I pretty sure it's fixed by 0f54e00e963

    @vstinner
    Copy link
    Member

    test_sendfile() hangs on AMD64 FreeBSD 10.x Shared 3.x buildbot: bpo-32708.

    @vstinner
    Copy link
    Member

    ProactorEventLoopTests.test_sendfile_close_peer_in_middle_of_receiving() leaks a reference on Windows: bpo-32710.

    @asvetlov
    Copy link
    Contributor Author

    New changeset a19fb3c by Andrew Svetlov in branch 'master':
    bpo-32622: Native sendfile on windows (bpo-5565)
    a19fb3c

    @miss-islington
    Copy link
    Contributor

    New changeset 632c1cb by Miss Islington (bot) in branch '3.7':
    bpo-32622: Native sendfile on windows (GH-5565)
    632c1cb

    @vstinner
    Copy link
    Member

    New changeset 2932755 by Victor Stinner in branch 'master':
    bpo-33353: test_asyncio uses smaller sendfile data (bpo-7083)
    2932755

    @vstinner
    Copy link
    Member

    New changeset b97de3d by Victor Stinner in branch 'master':
    bpo-33353: test_asyncio set SO_SNDBUF after connect (GH-7086)
    b97de3d

    @vstinner
    Copy link
    Member

    New changeset fa24c1c by Victor Stinner in branch '3.7':
    [3.7] bpo-33353: Fix test_asyncio on FreeBSD (GH-7087)
    fa24c1c

    @1st1
    Copy link
    Member

    1st1 commented May 29, 2018

    Closing this issue. Open new ones to track regressions/bugs.

    @1st1 1st1 closed this as completed May 29, 2018
    @vstinner
    Copy link
    Member

    vstinner commented Jan 8, 2019

    New changeset 80fda71 by Victor Stinner in branch 'master':
    bpo-35682: Fix _ProactorBasePipeTransport._force_close() (GH-11462)
    80fda71

    @miss-islington
    Copy link
    Contributor

    New changeset 88bd26a by Miss Islington (bot) in branch '3.7':
    bpo-35682: Fix _ProactorBasePipeTransport._force_close() (GH-11462)
    88bd26a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life topic-asyncio type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @1st1 @asvetlov @miss-islington