Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use autoconf to detect OpenSSL and libssl features #76779

Closed
tiran opened this issue Jan 19, 2018 · 3 comments
Closed

Use autoconf to detect OpenSSL and libssl features #76779

tiran opened this issue Jan 19, 2018 · 3 comments
Labels
3.7 (EOL) end of life extension-modules C modules in the Modules dir topic-installation type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Jan 19, 2018

BPO 32598
Nosy @tiran
PRs
  • bpo-32598: Use autoconf to detect usable OpenSSL #5242
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-01-20.12:21:53.184>
created_at = <Date 2018-01-19.13:48:26.381>
labels = ['extension-modules', 'type-bug', 'expert-installation', '3.7']
title = 'Use autoconf to detect OpenSSL and libssl features'
updated_at = <Date 2018-01-20.12:21:53.183>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2018-01-20.12:21:53.183>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-20.12:21:53.184>
closer = 'christian.heimes'
components = ['Extension Modules', 'Installation']
creation = <Date 2018-01-19.13:48:26.381>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 32598
keywords = ['patch']
message_count = 3.0
messages = ['310277', '310338', '310339']
nosy_count = 1.0
nosy_names = ['christian.heimes']
pr_nums = ['5242']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32598'
versions = ['Python 3.7']
    @tiran
    Copy link
    Member Author

    tiran commented Jan 19, 2018

    Starting with bpo-31399 Python will require some OpenSSL 1.0.2 features. The features are not available in LibreSSL yet. There is no easy way to detect the feature from setup.py. The inc_dir variable in setup.py does not reflect CPPFLAG. I tried "self.compiler.preprocess()" but run into more issues. For example prints to stderr in error cases.

    https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html makes it easy to check for working OpenSSL. It uses either pkg-config or falls back to manual detection in common locations.

    Based on the M4 macro it is easy to check for features like working X509_VERIFY_PARAM_set1_host() function.

    @tiran tiran added 3.7 (EOL) end of life extension-modules C modules in the Modules dir topic-installation type-bug An unexpected behavior, bug, or error labels Jan 19, 2018
    @tiran
    Copy link
    Member Author

    tiran commented Jan 20, 2018

    New changeset ff5be6e by Christian Heimes in branch 'master':
    bpo-32598: Use autoconf to detect usable OpenSSL (bpo-5242)
    ff5be6e

    @tiran
    Copy link
    Member Author

    tiran commented Jan 20, 2018

    Thanks, Andrew

    @tiran tiran closed this as completed Jan 20, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life extension-modules C modules in the Modules dir topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @tiran