Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _findvs into its own extension module #76769

Closed
zooba opened this issue Jan 17, 2018 · 4 comments
Closed

Move _findvs into its own extension module #76769

zooba opened this issue Jan 17, 2018 · 4 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life 3.8 only security fixes OS-windows performance Performance or resource usage stdlib Python modules in the Lib dir

Comments

@zooba
Copy link
Member

zooba commented Jan 17, 2018

BPO 32588
Nosy @pfmoore, @tjguk, @merwok, @zware, @zooba, @dstufft
PRs
  • bpo-32588: Move _findvs into its own module and add missing _queue module to installer #5227
  • [3.6] bpo-32588 Move _distutils_findvs into its own module (GH-5227) #5228
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2018-01-18.22:10:24.793>
created_at = <Date 2018-01-17.22:09:56.430>
labels = ['3.8', '3.7', 'library', 'OS-windows', 'performance']
title = 'Move _findvs into its own extension module'
updated_at = <Date 2018-01-18.22:10:24.792>
user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2018-01-18.22:10:24.792>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2018-01-18.22:10:24.793>
closer = 'steve.dower'
components = ['Distutils', 'Windows']
creation = <Date 2018-01-17.22:09:56.430>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 32588
keywords = ['patch']
message_count = 4.0
messages = ['310209', '310211', '310258', '310259']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'eric.araujo', 'zach.ware', 'steve.dower', 'dstufft']
pr_nums = ['5227', '5228']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue32588'
versions = ['Python 3.7', 'Python 3.8']
    @zooba
    Copy link
    Member Author

    zooba commented Jan 17, 2018

    The _findvs module I added for distutils has added load-time dependencies on the ole32 and oleaut32 DLLs.

    To reduce startup time, we should move _findvs into its own .pyd (unless I hear a better suggestion, I like "distutils._findvs.pyd").

    @zooba zooba added 3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir OS-windows performance Performance or resource usage labels Jan 17, 2018
    @zooba
    Copy link
    Member Author

    zooba commented Jan 17, 2018

    Actually, I'd prefer not dropping it into the Lib directory, so probably DLLs/_distutils_findvs.pyd is the way to go.

    @zooba zooba self-assigned this Jan 18, 2018
    @zooba
    Copy link
    Member Author

    zooba commented Jan 18, 2018

    New changeset 2507e29 by Steve Dower in branch 'master':
    bpo-32588: Move _findvs into its own module and add missing _queue module to installer (bpo-5227)
    2507e29

    @zooba
    Copy link
    Member Author

    zooba commented Jan 18, 2018

    New changeset ccf7f05 by Steve Dower in branch '3.6':
    [3.6] bpo-32588 Move _distutils_findvs into its own module (GH-5227) (bpo-5228)
    ccf7f05

    @zooba zooba closed this as completed Jan 18, 2018
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life 3.8 only security fixes OS-windows performance Performance or resource usage stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zooba