Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 567 #76617

Closed
1st1 opened this issue Dec 28, 2017 · 19 comments
Closed

Implement PEP 567 #76617

1st1 opened this issue Dec 28, 2017 · 19 comments
Assignees
Labels
3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@1st1
Copy link
Member

1st1 commented Dec 28, 2017

BPO 32436
Nosy @gvanrossum, @1st1, @miss-islington
PRs
  • bpo-32436: Implement PEP 567 #5027
  • bpo-32436: Remove a redundant assert #5275
  • bpo-32436: Fix potential NULL dereference #5286
  • bpo-32436: Don't use native popcount() (also fixes bpo-32641) #5292
  • bpo-32436: Fix a refleak and a GCC warning #5326
  • bpo-32436: Make PyContextVar_Get a little bit faster #5350
  • bpo-32436: Use PyThreadState_GET() in all hot paths #5363
  • bpo-32436: Add a default switch branch in _PyHamt_Eq #5370
  • bpo-32436: Fix compiler warning #5483
  • [3.7] bpo-32436: Fix compiler warning (GH-5483) #5486
  • bpo-32436: Add docs for contextvars #5685
  • [3.7] bpo-32436: Add docs for contextvars (GH-5685) #5699
  • bpo-32436: Document PEP 567 changes to asyncio. #7073
  • [3.7] bpo-32436: Document PEP 567 changes to asyncio. (GH-7073) #7077
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/1st1'
    closed_at = <Date 2018-02-16.16:48:43.585>
    created_at = <Date 2017-12-28.05:20:05.286>
    labels = ['interpreter-core', 'type-feature', 'library', '3.7']
    title = 'Implement PEP 567'
    updated_at = <Date 2018-05-23.17:59:21.172>
    user = 'https://github.com/1st1'

    bugs.python.org fields:

    activity = <Date 2018-05-23.17:59:21.172>
    actor = 'miss-islington'
    assignee = 'yselivanov'
    closed = True
    closed_date = <Date 2018-02-16.16:48:43.585>
    closer = 'yselivanov'
    components = ['Interpreter Core', 'Library (Lib)']
    creation = <Date 2017-12-28.05:20:05.286>
    creator = 'yselivanov'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 32436
    keywords = ['patch']
    message_count = 19.0
    messages = ['310451', '310452', '310455', '310456', '310457', '310458', '310474', '310523', '310553', '310703', '310812', '310873', '311472', '311473', '312239', '312240', '312242', '317429', '317433']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'yselivanov', 'miss-islington']
    pr_nums = ['5027', '5275', '5286', '5292', '5326', '5350', '5363', '5370', '5483', '5486', '5685', '5699', '7073', '7077']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32436'
    versions = ['Python 3.7']

    @1st1 1st1 added the 3.7 (EOL) end of life label Dec 28, 2017
    @1st1 1st1 self-assigned this Dec 28, 2017
    @1st1 1st1 added interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Dec 28, 2017
    @1st1
    Copy link
    Member Author

    1st1 commented Jan 23, 2018

    New changeset f23746a by Yury Selivanov in branch 'master':
    bpo-32436: Implement PEP-567 (bpo-5027)
    f23746a

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 23, 2018

    I'll keep the issue open -- a documentation for the new APIs will be merged in a separate PR in a couple of months.

    @gvanrossum
    Copy link
    Member

    Hopefully sooner?

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 23, 2018

    I'll try to find some time after beta-1. Right now have a few other issues that I have to finish (and also create a PR to make decimal use PEP-567).

    @gvanrossum
    Copy link
    Member

    While you're waiting for code review maybe you can review some other PR?
    (Lukasz mentioned that Serhiy seems very busy.)

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 23, 2018

    This one: #5273? I've left a comment with some questions there. Are there any other urgent PRs?

    The main PEP-567 PR has been merged already, btw.

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 23, 2018

    New changeset 83c8675 by Yury Selivanov in branch 'master':
    bpo-32436: Remove a redundant assert (bpo-5275)
    83c8675

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 23, 2018

    New changeset 0bad4d6 by Yury Selivanov in branch 'master':
    bpo-32436: Fix potential NULL dereference (bpo-5286)
    0bad4d6

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 24, 2018

    New changeset b7a80d5 by Yury Selivanov in branch 'master':
    bpo-32436: Don't use native popcount() (also fixes bpo-32641) (bpo-5292)
    b7a80d5

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 25, 2018

    New changeset 6ab6292 by Yury Selivanov in branch 'master':
    bpo-32436: Fix a refleak; var GC tracking; a GCC warning (bpo-5326)
    6ab6292

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 26, 2018

    New changeset 226e500 by Yury Selivanov in branch 'master':
    bpo-32436: Make PyContextVar_Get a little bit faster (bpo-5350)
    226e500

    @1st1
    Copy link
    Member Author

    1st1 commented Jan 27, 2018

    New changeset bc4123b by Yury Selivanov in branch 'master':
    bpo-32436: Use PyThreadState_GET() in all hot paths (GH-5363)
    bc4123b

    @1st1
    Copy link
    Member Author

    1st1 commented Feb 2, 2018

    New changeset 55e0839 by Yury Selivanov in branch 'master':
    bpo-32436: Fix compiler warning (bpo-5483)
    55e0839

    @1st1
    Copy link
    Member Author

    1st1 commented Feb 2, 2018

    New changeset 7876778 by Yury Selivanov (Miss Islington (bot)) in branch '3.7':
    bpo-32436: Fix compiler warning (GH-5483) (GH-5486)
    7876778

    @1st1
    Copy link
    Member Author

    1st1 commented Feb 16, 2018

    New changeset bd09335 by Yury Selivanov in branch 'master':
    bpo-32436: Add docs for contextvars (bpo-5685)
    bd09335

    @1st1
    Copy link
    Member Author

    1st1 commented Feb 16, 2018

    With the basic documentation committed, I'm now closing this issue.

    @1st1 1st1 closed this as completed Feb 16, 2018
    @miss-islington
    Copy link
    Contributor

    New changeset af6eaae by Miss Islington (bot) in branch '3.7':
    bpo-32436: Add docs for contextvars (GH-5685)
    af6eaae

    @1st1
    Copy link
    Member Author

    1st1 commented May 23, 2018

    New changeset 28b9178 by Yury Selivanov in branch 'master':
    bpo-32436: Document PEP-567 changes to asyncio. (GH-7073)
    28b9178

    @miss-islington
    Copy link
    Contributor

    New changeset 2fc443c by Miss Islington (bot) in branch '3.7':
    bpo-32436: Document PEP-567 changes to asyncio. (GH-7073)
    2fc443c

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life interpreter-core (Objects, Python, Grammar, and Parser dirs) stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants